fix(parsers): wrap over-long log line in sompasensecap (E501)#40
Open
laurigates wants to merge 1 commit into
Open
fix(parsers): wrap over-long log line in sompasensecap (E501)#40laurigates wants to merge 1 commit into
laurigates wants to merge 1 commit into
Conversation
The warning f-string introduced in #38 was 147 chars, exceeding the 120-char ruff limit and failing the tests (ruff check) CI job on master. Split into two implicitly-concatenated strings; message text unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request splits a long logging warning string into two lines in fvhiot/parsers/sompasensecap.py to improve readability. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split a 147-char warning f-string in
fvhiot/parsers/sompasensecap.pyinto two implicitly-concatenated strings so it fits the 120-char ruff limit. Message text is unchanged.Why
The
testsCI job isruff check --output-format=github .. The f-string introduced in #38 triggeredE501 Line too long (147 > 120), failing CI on master across all three Python versions (3.10/3.11/3.12) — and consequently on every open PR (including the Renovate onboarding PR #39).Verification
uvx ruff check .→All checks passed!locally; pre-commit ruff hook passed on push.🤖 Generated with Claude Code