Install Mockito as a JVM -javaagent on every Test task#4349
Open
ScottDugas wants to merge 1 commit into
Open
Conversation
Mockito's inline mock maker can no longer self-attach to a running JVM on JDK 21+, which (a) emits a warning that is scheduled to become an error and (b) races under parallel JUnit class execution, manifesting as IllegalStateException: Could not initialize plugin: interface org.mockito.plugins.MockMaker. Following Mockito's own JDK 21+ recommendation, declare a resolvable mockitoAgent configuration that resolves to the mockito-core jar and attach it via -javaagent to every Test JVM. The -javaagent flag is added inside a doFirst block so the mockitoAgent configuration is not resolved during evaluation, which would prevent the root build's resolutionStrategy.eachDependency callback from attaching to it. Closes FoundationDB#4334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mockito's inline mock maker can no longer self-attach to a running JVM on JDK 21+, which (a) emits a warning that is scheduled to become an error and (b) races under parallel JUnit class execution, manifesting as
IllegalStateException: Could not initialize plugin: interface org.mockito.plugins.MockMaker.Following Mockito's own JDK 21+ recommendation, declare a resolvable
mockitoAgentconfiguration that resolves to themockito-corejar and attach it via-javaagentto every Test JVM. The -javaagent flag is added inside adoFirstblock so themockitoAgentconfiguration is not resolved during evaluation, which would prevent the root build'sresolutionStrategy.eachDependencycallback from attaching to it.Closes #4334