Skip to content

[Feature] add resource automatic cost modification on attack or action#2062

Open
Skarlso wants to merge 4 commits into
Foundryborne:mainfrom
Skarlso:weapon-tokens
Open

[Feature] add resource automatic cost modification on attack or action#2062
Skarlso wants to merge 4 commits into
Foundryborne:mainfrom
Skarlso:weapon-tokens

Conversation

@Skarlso

@Skarlso Skarlso commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Description

Adds weapon resource decreasing on action or default attacks.

Screenshot 2026-07-04 at 12 24 28 Screenshot 2026-07-04 at 12 24 25 Screenshot 2026-07-04 at 12 24 18 Screenshot 2026-07-04 at 12 23 14 Screenshot 2026-07-04 at 12 05 54

I also added scrolling to the Settings page because resource was too low.

Screenshot_2026-07-04_at_12 19 31

Type of Change

Please check the relevant options:

  • Bug fix
  • New feature
  • Code cleanup/refactor
  • Documentation update
  • Test coverage
  • Dependency update
  • Configuration change
  • Other (please describe):

How Has This Been Tested?

Please describe the tests you ran to verify your changes:

  • Manual testing
  • Other:

Screenshots (if applicable)

Include screenshots or GIFs to help explain your changes visually.

Checklist

  • My code follows the project style guidelines
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix or feature works
  • New and existing tests pass locally with my changes

Additional Comments

Add any other context or questions here.


Thank you for your contribution! 🎉

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso

Skarlso commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-07-14 at 20 20 27 Screenshot 2026-07-14 at 20 19 33 Screenshot 2026-07-14 at 20 19 13 Screenshot 2026-07-14 at 20 19 07 Screenshot 2026-07-14 at 20 18 53 Screenshot 2026-07-14 at 20 06 41 Screenshot 2026-07-14 at 20 06 32 Screenshot 2026-07-14 at 20 06 15 Screenshot 2026-07-14 at 20 06 10

So I added reloading! :)

This is the next commit only for easy review.

Some caveats...

  • if the player has two weapons in their hands, both get reloaded. As far as I understand in order to do that selectively, I would have to thread the itemID through the entire thing. 🤔
  • I needed to add a choice for the healing effect to "Fully restore the resource". Because this is a full reload and not a counter.

Otherwise, I pretty much copied the healing part of the code. :)

Skarlso added 2 commits July 14, 2026 20:24
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant