[Rework] ChatMessage Damage#2079
Merged
Merged
Conversation
WBHarry
marked this pull request as ready for review
July 15, 2026 00:02
CarlosFdez
reviewed
Jul 15, 2026
CarlosFdez
reviewed
Jul 15, 2026
CarlosFdez
reviewed
Jul 15, 2026
Contributor
Author
|
I realised now that there are needed changes to TagTeamDialog aswell since it handles and saves damage data. |
CarlosFdez
reviewed
Jul 16, 2026
CarlosFdez
reviewed
Jul 16, 2026
…unctions and getters
…mageData) field. rollData.options.damage is retired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed so that
ActorRoll.Damageis hard defined inActorRoll.mjsinstead of just being a nebulous ObjectField.It's intended to hold keys for the various damage types IE
hitPoints,stressetc.The keyed objects hold the unaugmented JSON for the damage roll, aswell as auxiliary data like damageTypes used for hitPoint damage. Previously we were saving a -lot- of information that could easily go out of data and was very hard to keep track of. Now we can reroll the unagumented roll straight up and not have issues.