Skip to content

[Feature] Allow deleting countdowns via right click context menu on the main panel#2090

Open
CarlosFdez wants to merge 1 commit into
mainfrom
context-delete-countdown
Open

[Feature] Allow deleting countdowns via right click context menu on the main panel#2090
CarlosFdez wants to merge 1 commit into
mainfrom
context-delete-countdown

Conversation

@CarlosFdez

Copy link
Copy Markdown
Contributor
image

It also refactors the countdown rendering flow to occur based on the data updating, not a hook. There may be a double render somewhere I forgot to remove, but so far it seems to behave fine. There's also a change where the animation won't play on start updates, so that the initial configuration won't spam the animation.

@CarlosFdez

Copy link
Copy Markdown
Contributor Author

On the actual code itself, I don't know the purpose of this.data on the editor. Removing it, or having it fetch it again on re-render, might simplify things if we don't need to decouple it? Are there some temporary settings that don't lead to an update right away?

@CarlosFdez CarlosFdez changed the title Allow deleting countdowns via right click context menu on the main panel [Feature] Allow deleting countdowns via right click context menu on the main panel Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant