[Feature] Allow deleting countdowns via right click context menu on the main panel#2090
Open
CarlosFdez wants to merge 1 commit into
Open
[Feature] Allow deleting countdowns via right click context menu on the main panel#2090CarlosFdez wants to merge 1 commit into
CarlosFdez wants to merge 1 commit into
Conversation
Contributor
Author
|
On the actual code itself, I don't know the purpose of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also refactors the countdown rendering flow to occur based on the data updating, not a hook. There may be a double render somewhere I forgot to remove, but so far it seems to behave fine. There's also a change where the animation won't play on start updates, so that the initial configuration won't spam the animation.