fix(jellyfin): Refactor library parsing and valid activity when user …#403
Open
FoxxMD wants to merge 2 commits into
Open
fix(jellyfin): Refactor library parsing and valid activity when user …#403FoxxMD wants to merge 2 commits into
FoxxMD wants to merge 2 commits into
Conversation
Contributor
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…is non-admin
#402
Checklist before requesting a review
Type of change
Please delete options that are not relevant.
Describe your changes
getVirtualFoldersis only available to users with escalated privilegesgetUserViewsreturns similar information except thatLocationsis missing so we can't check library based on file pathgetAncestorsto try to get library name for newly seen media IdsThere is a breaking change/limitation with this change:
GetAncestorsonly returns the firstCollectionFolder(library) that an Item is added to. If the same media is in n+1 libraries and a user does not include the 1st library when usinglibrariesAlloworlibrariesBlockthen the media may accidentally be filtered out, or allowed, respectively.In this scenario a user must use API Key auth so that we can filter by Path, which will have the correct behavior.
Issue number and link, if applicable
#402