Skip to content

Fix some ec binary parsing typos #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnAZoidberg merged 1 commit into from
Mar 8, 2026
Merged

Fix some ec binary parsing typos #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions framework_lib/src/chromium_ec/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,16 +793,16 @@ impl CrosEc {
/// | Start | End | Size | Region |
/// | 00000 | 3BFFF | 3C000 | RO Region |
/// | 3C000 | 3FFFF | 04000 | Preserved |
/// | 40000 | 3C000 | 39000 | RO Region |
/// | 40000 | 78FFF | 39000 | RW Region |
/// | 79000 | 79FFF | 01000 | Preserved |
/// | 80000 | 80FFF | 01000 | Flash Flags |
///
/// NPC/Zephyr
/// | Start | End | Size | Region |
/// | 00000 | 3BFFF | 3C000 | RO Region |
/// | 3C000 | 3FFFF | 04000 | Preserved |
/// | 40000 | 3C000 | 39000 | RO Region |
/// | 79000 | 79FFF | 01000 | Flash Flags |
/// | 40000 | 78FFF | 39000 | RW Region |
/// | 7F000 | 7FFFF | 01000 | Flash Flags |
pub fn reflash(&self, data: &[u8], ft: EcFlashType, dry_run: bool) -> EcResult<()> {
let mut res = Ok(());

Expand Down Expand Up @@ -926,7 +926,7 @@ impl CrosEc {
println!(" RO verify success");
} else {
error!("RO verify fail!");
res = Err(EcError::DeviceError("RW verify fail!".to_string()));
res = Err(EcError::DeviceError("RO verify fail!".to_string()));
}
}

Expand Down