Merged
Conversation
It would say CreateFileW failed STATUS_SUCCESS. Signed-off-by: Daniel Schaefer <dhs@frame.work>
If the EC driver is not installed or runinng when the sensor driver starts, need to fail gracefully instead of preventing driver start and yellow bang. So instead we keep checking and connect to the EC at the first chance. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Member
Author
|
Running HLK now |
Member
Author
|
"DF - Sleep with IO during (Reliability)" keeps failing, even after running it three times. |
When suspending (D0 exit) close the handle to the EC driver so that we open it again after resume and get a fresh one. Because if the EC driver restarts during sleep, we cannot keep using the old handle pointing to the unloaded driver. This change just closes it, re-opening is already handled in OnTimerExpire when the device wakes. This fixes the HLK "DF - Sleep with IO during (Reliability)" test failure. Signed-off-by: Daniel Schaefer <dhs@frame.work>
…ction If the EC driver wasn't available during Initialize(), the sensor indices would still be the default values (lid=0, base=1) and never be updated. This would cause the driver to read from the wrong sensor. Add a flag to keep track of whether the indeces were checked already and initialize them if they weren't when reading sensor data. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Member
Author
|
Seems to work fine |
Check the boolean return directly and use GetLastError() on failure for proper error reporting. Signed-off-by: Daniel Schaefer <dhs@frame.work>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #19