Sensor autodetect and add hinge angle sensor#22
Draft
JohnAZoidberg wants to merge 2 commits intomainfrom
Draft
Conversation
JohnAZoidberg
changed the title
Query the EC at driver startup to determine which sensors are present instead of using #define ENABLE_* flags. Accelerometers are detected via EC_MEMMAP_ACC_STATUS presence bit and MOTIONSENSE_CMD_INFO. ALS is detected by enumerating motion sensors for MOTIONSENSE_TYPE_LIGHT, with a fallback to reading EC_MEMMAP_ALS. This allows a single driver binary to work across hardware configurations. Also fixes the ENABLE_ORIENTATIONACCEL_SENSOR typo in the old code. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Expose the EC-calculated lid hinge angle (0-360 degrees) to Windows via GUID_SensorType_HingeAngle / PKEY_SensorData_HingeAngle. The EC already computes this from base+lid accelerometers and stores it at EC_MEMMAP_ACC_DATA. The sensor is auto-detected when both base and lid accelerometers are present. Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
sensor-autodetect
branch
from
df95be8 to
28887e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.