[1.0.0] Use an optimized entry attribute encoder in the search path.#229
Merged
ChadSikorra merged 1 commit intoJul 19, 2026
Conversation
… sync). This provides a nearly 40% performance improvement in large searches / searches with entries that have many attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a nearly 40% performance improvement in large searches / searches with entries that have many attributes. The typical ASN1 path can be slow when there are lots of individual type objects to encode. This rears its head in the search path because of the all the entry attribute encoding that needs to happen. The changes are fairly minimal and are only done for the search path itself. The helper stays in the ASN1 library, so this library doesn't do have more ASN1 knowledge than it needs.
With this the subsearch / list path searches show p99 of 26ms - 47ms even on a directory of 50k entries (and the list example is an extreme case. under more realistic search patterns it's the same 26ms as the subsearch).