feat: Add IMAP storage support and enhanced UCP widget functionality#39
Open
88fingerslukee wants to merge 3 commits intoFreePBX:release/17.0from
Open
feat: Add IMAP storage support and enhanced UCP widget functionality#3988fingerslukee wants to merge 3 commits intoFreePBX:release/17.0from
88fingerslukee wants to merge 3 commits intoFreePBX:release/17.0from
Conversation
Member
|
Thanks a lot for your contribution. Could you please -
Thanks |
75063fe to
32fc181
Compare
Author
|
Sorry for the messy rebase, I screwed up. Do you want me to close this and re-submit a clean PR with the single commit? |
Member
|
Great I can see you did force rebase to single commit. however , can you please replace Thanks once again. |
7 tasks
…unctionality - Add comprehensive IMAP client for voicemail operations - Implement drag-and-drop interface for message management - Add folder creation/deletion functionality - Include IMAP connection testing feature - Enhance UI with modern styling and responsive design - Add 605 translation strings for internationalization Files modified: - ucp/includes/imap/ImapClient.php (NEW FILE) - ucp/Voicemail.class.php - Core UCP functionality - ucp/assets/js/global.js - Frontend JavaScript enhancements - ucp/assets/less/bootstrap.less - Styling improvements - ucp/views/widget.php - Widget view updates - ucp/views/greetings.php - Greetings view updates - functions.inc.php - Backend function updates - page.voicemail.php - Admin page updates - views/ssettings.php - Settings view updates
32fc181 to
b08800a
Compare
Author
|
@kguptasangoma Okay, I hope this is done correctly now. Please let me know any comments, questions or suggestions for this PR. I'll work on the documentation, but that might take some more time. |
- Fix authorization logic for greeting deletion (requires both greetings permission and extension check) - Fix delete command routing to properly fall through from authorization to deletion logic - Fix IMAP folder path construction issue (no more double VoiceMail/VoiceMail/Greetings) - Remove all debug logging for clean production code - Greeting deletion now works for both IMAP and local storage Fixes greeting deletion in UCP widget when using IMAP storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive IMAP storage support to the UCP voicemail widget and significantly enhances the user experience with modern UI improvements.
Problem
Solution
Changes Made
Core Functionality
ImapClient.phpclass for comprehensive IMAP supportVoicemail.class.phpwith IMAP integration methodsfunctions.inc.phpwith IMAP-related functions and connection testingUI/UX Improvements
IMAP Connection Testing Features
Files Modified
ucp/Voicemail.class.php- Core UCP functionalityucp/assets/js/global.js- Frontend JavaScript enhancementsucp/assets/less/bootstrap.less- Styling improvementsucp/includes/imap/ImapClient.php- New IMAP client with connection testing (NEW FILE)functions.inc.php- Backend function updates including IMAP connection test handlerTesting
Important Notes
Known Limitations
Breaking Changes
None - fully backward compatible
Checklist
Future Improvements