Skip to content

fix(backup): serialize datetime in directories JSONB #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-tet merged 1 commit into from
Apr 21, 2026
Merged

fix(backup): serialize datetime in directories JSONB #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions shard_core/database/backups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,22 @@
from psycopg.rows import dict_row
from psycopg.types.json import Jsonb

from shard_core.data_model.backup import BackupReport

async def insert(conn: AsyncConnection, report: dict) -> dict:

async def insert(conn: AsyncConnection, report: BackupReport) -> dict:
sql: LiteralString = """INSERT INTO backups (directories, start_time, end_time)
VALUES (%(directories)s, %(start_time)s, %(end_time)s)
RETURNING *"""
async with conn.cursor(row_factory=dict_row) as cur:
await cur.execute(
sql,
{
"directories": Jsonb(report["directories"]),
"start_time": report["startTime"],
"end_time": report["endTime"],
"directories": Jsonb(
[d.model_dump(mode="json") for d in report.directories]
),
"start_time": report.startTime,
"end_time": report.endTime,
},
)
return await cur.fetchone()
Expand Down
2 changes: 1 addition & 1 deletion shard_core/service/backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ async def backup_directories(
endTime=overall_end_time,
)
async with db_conn() as conn:
await db_backups.insert(conn, report.model_dump())
await db_backups.insert(conn, report)
_write_marker_blob(container_name, sas_token)
log.info("Backup done")

Expand Down
Loading