Skip to content

Fix compliance findings in Frends.IbmMaximo.Request (v1.2.0)#4

Merged
jefim merged 3 commits into
mainfrom
copilot/fix-compliance-findings
Jul 23, 2026
Merged

Fix compliance findings in Frends.IbmMaximo.Request (v1.2.0)#4
jefim merged 3 commits into
mainfrom
copilot/fix-compliance-findings

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Resolves task scanner compliance findings: missing csproj metadata, net6.0 target, absent Options parameter on the main task method, and missing <example> XML doc tags.

csproj

  • Added <Company>Frends</Company> and <Product>Frends</Product>
  • Changed <PackageProjectUrl> to https://frends.com/
  • Upgraded target framework: net6.0net8.0
  • Bumped version 1.1.01.2.0

New Options parameter (FT0007)

Added Options class and wired it into the main Request entry point:

public static async Task<Result> Request(
    [PropertyTab] Input input,
    [PropertyTab] Options options,   // new
    CancellationToken cancellationToken)

Options exposes ThrowErrorOnFailure (default true) and ErrorMessageOnFailure. The method now wraps dispatch in a try/catch that either rethrows or returns Result(Success=false) based on those settings. Sub-methods (CreateWorkOrder, CustomRequest, etc.) are unchanged.

XML documentation (FT0014)

Added <example> tags to the 13 Input properties that were missing them (RequestType, WorkOrderDescription, ServiceRequestDescription, ReportedBy, WorkOrderLocation, ServiceRequestLocation, WorkOrderAssetNum, ServiceRequestAssetNum, Site, ScheduledStart, ReportedDate, WorkOrderId, ServiceRequestId).

Copilot AI changed the title [WIP] Fix compliance findings in Frends.IbmMaximo.Request Fix compliance findings in Frends.IbmMaximo.Request (v1.2.0) Jul 23, 2026
Copilot finished work on behalf of jefim July 23, 2026 05:37
Copilot AI requested a review from jefim July 23, 2026 05:37

@jefim jefim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot address the review comments

Comment thread Frends.IbmMaximo.Request/CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
# Changelog

## [1.2.0] - 2026-07-23

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new Options parameter to the task signature is a breaking change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct — bumped to 2.0.0 in the csproj and CHANGELOG. Fixed in commit $(git rev-parse --short HEAD).

Copilot finished work on behalf of jefim July 23, 2026 10:59
Copilot AI requested a review from jefim July 23, 2026 10:59
@jefim
jefim marked this pull request as ready for review July 23, 2026 10:59
@jefim
jefim merged commit 5a293ed into main Jul 23, 2026
5 checks passed
@jefim
jefim deleted the copilot/fix-compliance-findings branch July 23, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants