Fix compliance findings in Frends.IbmMaximo.Request (v1.2.0)#4
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix compliance findings in Frends.IbmMaximo.Request
Fix compliance findings in Frends.IbmMaximo.Request (v1.2.0)
Jul 23, 2026
jefim
requested changes
Jul 23, 2026
| @@ -1,5 +1,11 @@ | |||
| # Changelog | |||
|
|
|||
| ## [1.2.0] - 2026-07-23 | |||
Contributor
There was a problem hiding this comment.
Adding a new Options parameter to the task signature is a breaking change
Contributor
Author
There was a problem hiding this comment.
Correct — bumped to 2.0.0 in the csproj and CHANGELOG. Fixed in commit $(git rev-parse --short HEAD).
jefim
marked this pull request as ready for review
July 23, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves task scanner compliance findings: missing csproj metadata, net6.0 target, absent
Optionsparameter on the main task method, and missing<example>XML doc tags.csproj
<Company>Frends</Company>and<Product>Frends</Product><PackageProjectUrl>tohttps://frends.com/net6.0→net8.01.1.0→1.2.0New
Optionsparameter (FT0007)Added
Optionsclass and wired it into the mainRequestentry point:OptionsexposesThrowErrorOnFailure(defaulttrue) andErrorMessageOnFailure. The method now wraps dispatch in atry/catchthat either rethrows or returnsResult(Success=false)based on those settings. Sub-methods (CreateWorkOrder,CustomRequest, etc.) are unchanged.XML documentation (FT0014)
Added
<example>tags to the 13Inputproperties that were missing them (RequestType,WorkOrderDescription,ServiceRequestDescription,ReportedBy,WorkOrderLocation,ServiceRequestLocation,WorkOrderAssetNum,ServiceRequestAssetNum,Site,ScheduledStart,ReportedDate,WorkOrderId,ServiceRequestId).