Skip to content

Fix copyright compliance in Frends.Pgp.SignFile csproj#16

Merged
jefim merged 4 commits into
mainfrom
copilot/fix-compliance-findings-in-frends-pgp-signfile
Jul 24, 2026
Merged

Fix copyright compliance in Frends.Pgp.SignFile csproj#16
jefim merged 4 commits into
mainfrom
copilot/fix-compliance-findings-in-frends-pgp-signfile

Conversation

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The <Copyright> tag in Frends.Pgp.SignFile.csproj didn't satisfy the platform compliance rule requiring <Copyright>Frends</Copyright>.

Changes

  • Frends.Pgp.SignFile.csproj: Replace Copyright (c) 2026 Frends EiPaaS with Frends; bump version 1.2.01.3.0
  • CHANGELOG.md: Add [1.3.0] entry
<!-- Before -->
<Copyright>Copyright (c) 2026 Frends EiPaaS</Copyright>

<!-- After -->
<Copyright>Frends</Copyright>

Copilot AI changed the title [WIP] Fix compliance findings in Frends.Pgp.SignFile Fix copyright compliance in Frends.Pgp.SignFile csproj Jul 24, 2026
Copilot AI requested a review from jefim July 24, 2026 05:13
Copilot finished work on behalf of jefim July 24, 2026 05:13
@jefim
jefim marked this pull request as ready for review July 24, 2026 05:14
@jefim

jefim commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@copilot fix the build issues

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix the build issues

Fixed in the latest commit. NUnit 4.6.1 (resolved by the 4.* wildcard) introduced an Action overload for Assert.Throws that conflicted with the existing TestDelegate overload, causing CS0121. Pinned NUnit to 4.3.2 and NUnit3TestAdapter to 5.0.0 (matching the EncryptFile project which already builds cleanly). The solution now builds without errors.

Copilot finished work on behalf of jefim July 24, 2026 05:17

@jefim jefim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot address review comments

<PackageReference Include="coverlet.collector" Version="6.*" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.*" />
<PackageReference Include="NUnit" Version="4.*" />
<PackageReference Include="NUnit3TestAdapter" Version="6.*" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, leave the 4.* and 6.* versions, and fix the unit tests instead

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the version pin. Fixed the unit tests by casting each Assert.Throws lambda to (Action), which resolves the CS0121 ambiguity introduced in NUnit 4.6+ and uses the new preferred overload. Solution builds with 0 errors and 0 warnings.

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@copilot address review comments

Done — reverted the NUnit version pin and fixed the unit tests by casting the lambdas to (Action) instead.

Copilot finished work on behalf of jefim July 24, 2026 05:23
Copilot AI requested a review from jefim July 24, 2026 05:23
@jefim
jefim merged commit 0e01f90 into main Jul 24, 2026
5 checks passed
@jefim
jefim deleted the copilot/fix-compliance-findings-in-frends-pgp-signfile branch July 24, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants