[2.x] Update to opis/closure v4 and fix PHPStan#80
Open
dsevillamartin wants to merge 3 commits into2.xfrom
Open
[2.x] Update to opis/closure v4 and fix PHPStan#80dsevillamartin wants to merge 3 commits into2.xfrom
dsevillamartin wants to merge 3 commits into2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Replace the closure package, which itself provided more modern support for opis/closure back in the day, with the original package that supports PHP 8.0-8.5. The old one had not been updated in 3+ years.
There was a package rewrite with v4, but this only affects the data unserializing, and there's a v3 compatibility mode I enabled in case a queued job was created before the upgrade -- though not sure if we should really support this use case anyways. Unsure of what the harm on enabling the compat mode is.
Update PHPStan config so that it works again after major upgrade in flarum/phpstan package
Confirmed
Frontend changes: tested on a local Flarum installation.composer test).