Skip to content

fix desktop build error#2

Merged
FrilLab merged 1 commit into
mainfrom
fixed/ci_error
Jun 27, 2026
Merged

fix desktop build error#2
FrilLab merged 1 commit into
mainfrom
fixed/ci_error

Conversation

@FrilLab

@FrilLab FrilLab commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • what changed?
  • why did it change?

Scope

  • apps/desktop
  • apps/server
  • crates/frilday-core
  • docs

Delete any lines that do not apply.

Validation

  • apps/desktop: npm run lint
  • apps/desktop: npm run build
  • apps/server: cargo check --manifest-path apps/server/Cargo.toml
  • crates/frilday-core: cargo check --manifest-path crates/frilday-core/Cargo.toml

Notes

  • architectural impact, follow-up work, or risks

Summary by CodeRabbit

  • Bug Fixes

    • Improved task form updates so category and custom day selections stay in sync more reliably.
    • Refined date handling so the weekly schedule starts correctly after the app finishes loading.
  • Chores

    • Updated ignore rules for common build and generated files across the project.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 289bb572-00b3-487d-9e20-98abd36b9d4e

📥 Commits

Reviewing files that changed from the base of the PR and between 46c3476 and 8ee0364.

⛔ Files ignored due to path filters (2)
  • apps/server/Cargo.lock is excluded by !**/*.lock
  • crates/frilday-core/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • .gitignore
  • apps/desktop/eslint.config.js
  • apps/desktop/src/app/App.tsx
  • apps/desktop/src/features/task/components/TaskForm.tsx

📝 Walkthrough

Walkthrough

The PR expands repository and desktop ignore patterns, updates desktop ESLint ignores and a React Refresh override, and adjusts two desktop components to derive week and form state with React hooks.

Changes

Desktop tooling configuration

Layer / File(s) Summary
Repository ignore patterns
.gitignore
.DS_Store, recursive node_modules, dist, and target paths, plus apps/desktop/src-tauri/gen/, are added to .gitignore.
Desktop ESLint settings
apps/desktop/eslint.config.js
globalIgnores now includes additional build directories, and src/main.tsx gets a scoped react-refresh/only-export-components override.

Desktop component hooks

Layer / File(s) Summary
Schedule week memoization
apps/desktop/src/app/App.tsx
scheduleWeekStartYmd is derived with useMemo before the hydration guard.
Task form watched fields
apps/desktop/src/features/task/components/TaskForm.tsx
TaskForm switches to useWatch with control for category and customDays.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Hop hop, the burrow's tidy and bright,
.DS_Store crumbs have taken flight.
useWatch keeps the carrot-clock in view,
While week-start values memoize too.
A soft lint nudge, and onward I hop! 🐰

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is just the template with placeholders, so it does not describe the actual changes or validation. Replace the placeholders with a filled-in summary, scope limited to the touched areas, completed validation results, and any relevant notes or risks.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and directly refers to the desktop build fix.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixed/ci_error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@FrilLab FrilLab merged commit 002ef2e into main Jun 27, 2026
3 checks passed
@FrilLab FrilLab deleted the fixed/ci_error branch June 27, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants