Skip to content

Update Cargo.toml files#84

Merged
mors119 merged 1 commit into
FrilLab:mainfrom
mors119:refactor/cargo-toml
Jun 22, 2026
Merged

Update Cargo.toml files#84
mors119 merged 1 commit into
FrilLab:mainfrom
mors119:refactor/cargo-toml

Conversation

@mors119

@mors119 mors119 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Update Cargo.toml files

Manage packages commonly using the root Cargo.toml.

Type of Change

  • feat
  • fix
  • docs
  • refactor
  • test
  • chore

Required

  • cargo check passes
  • cargo fmt --all --check passes
  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test passes

Checklist

  • Code builds successfully
  • Tests pass
  • Documentation updated

Summary by CodeRabbit

  • Chores

    • Updated workspace configuration to centralize dependency management and package metadata.
    • Enhanced build optimizations including link-time optimization, code stripping, and panic handling for release builds.
    • Implemented stricter code quality policies forbidding unsafe code and enabling additional compiler warnings.
  • Tests

    • Re-enabled and updated file move operation test coverage.

@mors119 mors119 merged commit 29679b4 into FrilLab:main Jun 22, 2026
2 checks passed
@mors119 mors119 deleted the refactor/cargo-toml branch June 22, 2026 12:20
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9243ee5d-e1e5-4530-b7c0-ba8bdd6a8983

📥 Commits

Reviewing files that changed from the base of the PR and between 93f1496 and 1824ce4.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml
  • apps/frilvault-cli/Cargo.toml
  • crates/frilvault-core/Cargo.toml
  • crates/frilvault-core/src/tests/repair_engin_test.rs

📝 Walkthrough

Walkthrough

The root Cargo.toml workspace gains a resolver upgrade to "3", centralized [workspace.package] metadata, [workspace.dependencies] with pinned crate versions, workspace-wide lint rules, and an optimized [profile.release]. Member crates frilvault-cli and frilvault-core are updated to inherit those settings. A previously commented-out repair engine test is re-enabled.

Changes

Cargo Workspace Modernization and Repair Engine Test Fix

Layer / File(s) Summary
Root workspace metadata, deps, lints, and release profile
Cargo.toml
Resolver set to "3"; [workspace.package] defines edition 2024, MIT license, and repository; [workspace.dependencies] pins chrono, serde, uuid, thiserror; [workspace.lints] forbids unsafe_code and enables Clippy warnings; [profile.release] enables LTO, codegen-units=1, symbol stripping, and panic = "abort".
Member crate adoption of workspace settings
apps/frilvault-cli/Cargo.toml, crates/frilvault-core/Cargo.toml
Both crates replace explicit edition, license, repository with workspace = true; both add [lints] workspace = true; frilvault-core moves chrono, serde, uuid, thiserror to workspace deps; frilvault-cli moves uuid to workspace dep and adds publish = false.
Re-enabled repair engine file-move test
crates/frilvault-core/src/tests/repair_engin_test.rs
Commented-out repair_engine_moves_note_files is rewritten as an active #[test] that creates a note, applies a FileMove via RepairEngine::apply_moves, and asserts the old path is absent and the new path exists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • FrilLab/frilvault#83: Previously commented out or removed the repair_engine_moves_note_files test in the same file that this PR re-enables and rewrites.

Poem

🐇 Hop hop, the workspace is tidy and neat,
One place for editions, licenses, all sweet!
unsafe_code banned with a thump of my paw,
LTO enabled — no slack in the jaw.
The repair test leaps back from commented gloom,
Notes move and verify — there's no more dark doom! 🌿

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant