Skip to content

refator(core): delete not to use items#86

Merged
mors119 merged 1 commit into
FrilLab:mainfrom
mors119:refactor/delete-not-to-use
Jun 26, 2026
Merged

refator(core): delete not to use items#86
mors119 merged 1 commit into
FrilLab:mainfrom
mors119:refactor/delete-not-to-use

Conversation

@mors119

@mors119 mors119 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Describe your changes.

Type of Change

  • feat
  • fix
  • docs
  • refactor
  • test
  • chore

Required

  • cargo check passes
  • cargo fmt --all --check passes
  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test passes

Checklist

  • Code builds successfully
  • Tests pass
  • Documentation updated

Summary by CodeRabbit

  • Refactor
    • Cleaned up the app’s internal structure by reorganizing note-related components under a single, consistent module path.
    • Streamlined how note and workspace features are wired together, with no changes to end-user behavior or existing functionality.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9463fb1a-cffe-4bd2-86e1-6c37e6d03417

📥 Commits

Reviewing files that changed from the base of the PR and between 53db17d and 84403a1.

📒 Files selected for processing (8)
  • crates/frilvault-core/src/app/frilvault.rs
  • crates/frilvault-core/src/lib.rs
  • crates/frilvault-core/src/note/mod.rs
  • crates/frilvault-core/src/note/note_repository.rs
  • crates/frilvault-core/src/runtime/vault_context.rs
  • crates/frilvault-core/src/storage/mod.rs
  • crates/frilvault-core/src/tests/helper.rs
  • crates/frilvault-core/src/workspace/repository/workspace_index_repository.rs
💤 Files with no reviewable changes (2)
  • crates/frilvault-core/src/storage/mod.rs
  • crates/frilvault-core/src/lib.rs

📝 Walkthrough

Walkthrough

NoteRepository now comes from the note module instead of storage. The note module re-exports the repository, the storage module drops its repository export, and all affected imports switch to the new path.

Changes

Note repository module wiring

Layer / File(s) Summary
Module surface change
crates/frilvault-core/src/note/mod.rs, crates/frilvault-core/src/storage/mod.rs, crates/frilvault-core/src/lib.rs
note_repository is re-exported from note, storage no longer re-exports repository, and the crate root removes mod storage;.
Import path updates
crates/frilvault-core/src/app/frilvault.rs, crates/frilvault-core/src/runtime/vault_context.rs, crates/frilvault-core/src/workspace/repository/workspace_index_repository.rs, crates/frilvault-core/src/tests/helper.rs
Call sites switch NoteRepository and NoteService imports from storage to note.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • FrilLab/frilvault#48: Introduced the note::NoteRepository path that this PR now imports from.
  • FrilLab/frilvault#78: Updates VaultContext around NoteRepository, matching the import path change in this PR.
  • FrilLab/frilvault#81: Changes the core module surface and re-export layout in the same area as this PR’s lib.rs and storage/mod.rs edits.

Poem

A bunny hopped through modules bright,
From storage paths to note just right.
Re-exports twinkled, imports aligned,
The carrot trail of code is kind. 🐇
Hoppity-hop, all tidy tonight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the refactor, but it is too vague and awkward to clearly describe the actual cleanup work. Rename it to a concise, specific summary such as "refactor(core): remove unused storage re-exports and imports".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mors119 mors119 merged commit 133c573 into FrilLab:main Jun 26, 2026
3 checks passed
@mors119 mors119 deleted the refactor/delete-not-to-use branch June 26, 2026 03:34
@mors119 mors119 restored the refactor/delete-not-to-use branch June 26, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant