unstable-feature/theme: Delegate rendering to classes#8
Open
cambell-prince wants to merge 6 commits intoFrontAccountingERP:unstablefrom
Open
unstable-feature/theme: Delegate rendering to classes#8cambell-prince wants to merge 6 commits intoFrontAccountingERP:unstablefrom
cambell-prince wants to merge 6 commits intoFrontAccountingERP:unstablefrom
Conversation
…, and ListRenderer delegation
- Previously this rendered directly via echo.
…to renderer.
- Added function ControlRenderer::table_add_cells to render cells.
- Moved direct rendering out of gl_bank_ui
- Ensure that all variables are passed in the InputRenderer delegation - Fix the call to refs normalize in refs_cells during initialization so that it doesn't use the possibly null init value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces rendering classes so that the actual rendering of html elements can be delegated to themes where required. The PR is intended to be a minimal change to achieve this effect. The changes diff well with the existing implementation e.g. ui_control.inc <-> ControlRenderer.inc which in turn diffs well with the separate bootstrap theme implementation. This simplifies maintaining the feature until such time as it is integrated into FA. Once integrated I would refactor further to improve the rendering code both for the default themes and the bootstrap theme.