New feature Y by Dimitry-bit · Pull Request #19 · Frozen-Bytes/nowinandroid

Dimitry-bit · 2026-04-16T10:07:15Z

No description provided.

Rename package properly

* Bump protobufPlugin 0.9.6 Change-Id: I9f4174946f043c79bba9a669655f6654036b5679 * Change Android library to Jvm library. Change-Id: I20ca1f71610f26a18d4573b3122994bc32c18723 * Enable newDsl. Change-Id: Ifb855133593f64771e81f60b96c3e34d946dac8f * Update README. Change-Id: I3df518dd4a5f37ba7ca6e568914783b1ea417fce

* Apply spotless by default - Upgrades to spotless 8.2.1 - Moves spotless setup from an init.gradle.kts to build-logic - Narrows down the scope of `target` in spotless configuration to be more precise to workaround diffplug/spotless#2717 - Updates all references to init.gradle.kts Ran gradle-profiler ./gradlew build --dry-run to validate performance impact. Before PR: Mean 10,527.96 ms with 289.01 ms std dev After PR: Mean 11,251.78 ms with 530.29 ms std dev Regression is there, but quite minor. Test: ./gradlew spotlessCheck * Address comments from AI overlords * Fix usage of rootProject * Enable spotless for build-logic via root project

- Enable KSP isolated projects support google/ksp#1752 - Disable spotless in isolated projects mode diffplug/spotless#1979 - Disable graph tasks in isolated projects mode android#1842 Test: ./gradlew build -Dorg.gradle.unsafe.isolated-projects=true --dry-run

Test: ./gradlew app:assembleDebug

This picks up a fix for Gradle project isolation diffplug/spotless#1979 This makes progress on android#1842 Test: ./gradlew build -Dorg.gradle.unsafe.isolated-projects=true --dry-run

perfpulse · 2026-04-16T11:16:44Z

📊 Android Performance Analysis Report

Warning

Detected regression for 2 Macrobenchmark(s). Further investigation is required.

🔎 Summary

MacroBenchmark	Metric	Status
BookmarkForYouArticle	️Frame Rendering Time	🔴 Regression
BookmarkForYouArticle	Memory Usage	⚪ Insignificant
StartupTime	App Launch Time	🔴 Regression

⌛ Benchmarks

BookmarkForYouArticle

Name: bookmarkForYouArticle
Class: com.google.samples.apps.nowinandroid.Generator.BookmarkForYouArticle_Bench
- Extra Execution Metadata
  
  Device Runtime (sec) Repeat Iterations Warmup Iterations
  
  Nexus_6 866 - 1240 50 - 50 5 - 5
  
  Pixel 844 - 1056 50 - 50 5 - 5
- ️Frame Rendering Time
  
  Mann-Whitney U-Test (threshold = 0.010)
  
  Device Median Change (%) Statistic Status
  
  Nexus_6 5679 ms vs 14257 ms 8577 (+151%) p=+0.004 🔴 Regression
  
  Pixel 3322 ms vs 8488 ms 5166 (+155%) p=+0.004 🔴 Regression
  
  Step Fit (threshold = 5.000)
  
  Device Median Change (%) Statistic Status
  
  Nexus_6 5679 ms vs 14257 ms 8577 (+151%) fit=-144.030 🔴 Regression
  
  Pixel 3322 ms vs 8488 ms 5166 (+155%) fit=-16.963 🔴 Regression
  - 🗃️ Raw Runs
    
    📱 Nexus_6
    
    Run Baseline Candidate Change
    
    0 5690 ms 14257 ms +151%
    
    1 5592 ms 14301 ms +156%
    
    2 5487 ms 13903 ms +153%
    
    3 5861 ms 14095 ms +140%
    
    4 5679 ms 14614 ms +157%
    
    📱 Pixel
    
    Run Baseline Candidate Change
    
    0 3416 ms 8324 ms +144%
    
    1 3362 ms 6550 ms +95%
    
    2 436 ms 8560 ms +1861%
    
    3 3322 ms 8488 ms +155%
    
    4 3302 ms 8692 ms +163%
- Memory Usage
  
  Mann-Whitney U-Test (threshold = 0.010)
  
  Device Median Change (%) Statistic Status
  
  Nexus_6 167352 Kb vs 168614 Kb 1262 (+1%) p=+0.500 ⚪ Insignificant
  
  Pixel 157798 Kb vs 155402 Kb -2396 (-2%) p=+0.075 ⚪ Insignificant
  
  Step Fit (threshold = 5.000)
  
  Device Median Change (%) Statistic Status
  
  Nexus_6 167352 Kb vs 168614 Kb 1262 (+1%) fit=-1.486 ⚪ Insignificant
  
  Pixel 157798 Kb vs 155402 Kb -2396 (-2%) fit=+3.409 ⚪ Insignificant
  - 🗃️ Raw Runs
    
    📱 Nexus_6
    
    Run Baseline Candidate Change
    
    0 167448 Kb 169120 Kb +1%
    
    1 167352 Kb 166530 Kb -0%
    
    2 170148 Kb 172516 Kb +1%
    
    3 167204 Kb 166368 Kb -0%
    
    4 166786 Kb 168614 Kb +1%
    
    📱 Pixel
    
    Run Baseline Candidate Change
    
    0 161654 Kb 141840 Kb -12%
    
    1 156240 Kb 159404 Kb +2%
    
    2 155496 Kb 153502 Kb -1%
    
    3 160098 Kb 155402 Kb -3%
    
    4 157798 Kb 156448 Kb -1%
StartupTime

Name: startupTime
Class: com.google.samples.apps.nowinandroid.Generator.GeneratedStartupBenchmark
- Extra Execution Metadata
  
  Device Runtime (sec) Repeat Iterations Warmup Iterations
  
  Nexus_6 368 - 394 50 - 50 5 - 5
  
  Pixel 354 - 366 50 - 50 5 - 5
- App Launch Time
  
  Mann-Whitney U-Test (threshold = 0.010)
  
  Device Median Change (%) Statistic Status
  
  Nexus_6 1579 ms vs 1952 ms 372 (+24%) p=+0.004 🔴 Regression
  
  Pixel 1505 ms vs 1633 ms 128 (+9%) p=+0.004 🔴 Regression
  
  Step Fit (threshold = 5.000)
  
  Device Median Change (%) Statistic Status
  
  Nexus_6 1579 ms vs 1952 ms 372 (+24%) fit=-9.594 🔴 Regression
  
  Pixel 1505 ms vs 1633 ms 128 (+9%) fit=-7.488 🔴 Regression
  - 🗃️ Raw Runs
    
    📱 Nexus_6
    
    Run Baseline Candidate Change
    
    0 1617 ms 1772 ms +10%
    
    1 1579 ms 1952 ms +24%
    
    2 1480 ms 1704 ms +15%
    
    3 1567 ms 1962 ms +25%
    
    4 1673 ms 2039 ms +22%
    
    📱 Pixel
    
    Run Baseline Candidate Change
    
    0 1505 ms 1689 ms +12%
    
    1 1425 ms 1633 ms +15%
    
    2 1357 ms 1622 ms +20%
    
    3 1608 ms 1828 ms +14%
    
    4 1511 ms 1611 ms +7%

📱 Device Specifications

Device	Brand	CPU	Memory	SDK
Nexus_6	google	2-cores @ 2000 Hz	3 GB	34 (REL)
Pixel	google	2-cores @ 2000 Hz	2 GB	34 (REL)

abdllrhmanzedan · 2026-04-16T11:36:19Z

I will investigate the code changes and rerun benchmarks before proceeding 😅

Dimitry-bit and others added 20 commits March 9, 2026 20:16

ci: set scrollforyou frametime benchmark

ddb01f8

perf: add 4 items each with 25ms regression to foryou screen

d7a7d0b

Merge branch 'main' into bench-scrollforyou-reg

b1e661c

Merge pull request android#2045 from Jaehwa-Noh/rename-package

9b0ab20

Rename package properly

Upgrade to Gradle 9.4.0

037aaa7

Test: ./gradlew app:assembleDebug

Upgrade to spotless 8.3.0

7c3608c

This picks up a fix for Gradle project isolation diffplug/spotless#1979 This makes progress on android#1842 Test: ./gradlew build -Dorg.gradle.unsafe.isolated-projects=true --dry-run

Update README files that contained old svg references

b0749eb

fix: use correct test tag in BookmarksScreen LoadingState

0b86faa

undo a bunch of extra changes

eb3d48d

Add phone in landscape

3b9e41c

perf: add 100ms startup regression

7ccc42e

Merge branch 'bench-scrollforyou-reg' into feature

ed88cce

feat: added a new feature

c26d4ee

ci: focus on TID, FFO, MEM_RSS_MAX measures

3577420

refactor: correct benchmark naming convention

76f64ba

bench: implement multi-metric optimization

1c331a2

chore: setup for demo

1975f7a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New feature Y#19

New feature Y#19
Dimitry-bit wants to merge 20 commits intomainfrom
new-feature-y

Dimitry-bit commented Apr 16, 2026

Uh oh!

perfpulse bot commented Apr 16, 2026

Mann-Whitney U-Test (threshold = 0.010)

Step Fit (threshold = 5.000)

Mann-Whitney U-Test (threshold = 0.010)

Step Fit (threshold = 5.000)

Mann-Whitney U-Test (threshold = 0.010)

Step Fit (threshold = 5.000)

Uh oh!

abdllrhmanzedan commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

Dimitry-bit commented Apr 16, 2026

Uh oh!

perfpulse bot commented Apr 16, 2026

📊 Android Performance Analysis Report

🔎 Summary

⌛ Benchmarks

Mann-Whitney U-Test (threshold = 0.010)

Step Fit (threshold = 5.000)

Mann-Whitney U-Test (threshold = 0.010)

Step Fit (threshold = 5.000)

Mann-Whitney U-Test (threshold = 0.010)

Step Fit (threshold = 5.000)

📱 Device Specifications

Uh oh!

abdllrhmanzedan commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants