feat(emoji): add Unicode 15.1 & 16.0 emoji#550
Merged
Conversation
Owner
|
Thanks for this! @judekim0507 once you fix greptile comments then we can merge 🔥 |
Contributor
Author
|
@FuJacob thanks for reviewing! pushed the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bundled emoji catalog (
Resources/Emoji/emoji.json) was capped at Unicode 15.0, so newer glyphs like face with bags under eyes never appeared in the:emoji:picker. Upstream github/gemoji is itself stale at 15.0, so this sources the gap from emojibase and appends the 36 missing emoji (28 from Unicode 15.1, 8 from 16.0). Reason: I use a little too much.Greptile Summary
This PR extends the bundled emoji catalog from Unicode 15.0 to 16.0 by appending 36 new entries directly to
emoji.json, sourced from emojibase to fill the gap left by the stale upstream gemoji library.face_with_bags_under_eyes,fingerprint,leafless_tree,root_vegetable,harp,shovel,splatter, and theflag: Sark(🇨🇶).glyph,name,aliases,keywords,group,unicodeVersion) and the alias/keyword conventions used throughout the file.Confidence Score: 5/5
Data-only change appending well-formed JSON objects; no logic paths are touched and the existing emoji array is not modified.
The change is purely additive — 36 new JSON entries appended to the catalog. Each entry has the correct schema fields, group assignments match Unicode spec categories, alias naming follows the existing snake_case convention, and keyword sets are consistent with analogous existing entries. JSON structure remains valid.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["emoji.json (Unicode ≤15.0)"] -->|"append 28 glyphs"| B["Unicode 15.1 block\n(family variants, directional movement,\nphoenix, lime, brown mushroom,\nbroken chain, head-shake emojis)"] A -->|"append 8 glyphs"| C["Unicode 16.0 block\n(face_with_bags_under_eyes, fingerprint,\nleafless_tree, root_vegetable, harp,\nshovel, splatter, flag: Sark)"] B --> D["emoji.json (Unicode ≤16.0)"] C --> D D -->|"parsed at runtime"| E["Emoji Picker\n(:emoji: completions)"]Reviews (2): Last reviewed commit: "fix(emoji): drop stray man keyword from ..." | Re-trigger Greptile