README: uniform demo gif sizing in the 2x2 grid#611
Merged
Conversation
Comment on lines
+52
to
+53
| | | | | ||
| |:---:|:---:| |
Contributor
There was a problem hiding this comment.
The markdown table's empty header row (
| | |) renders as a thin visible row above the GIF cells. There is no way to omit the header row in GFM syntax; this is a known markdown table limitation. The empty cells are fine as-is — just noting it renders a slightly elevated first row of GIFs, which is likely acceptable but worth being aware of as intentional.
Suggested change
| | | | | |
| |:---:|:---:| | |
| | | | | |
| |:---:|:---:| |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the demo gif grid from a raw HTML table to a markdown table with explicit width and height on every img, so GitHub renders all four cells at an identical 440x220 box instead of falling back to native aspect ratios. The four source gifs vary from 1.7:1 to 2.9:1, so a uniform render size means a slight stretch but a clean grid.
Validation
Visual; previewed locally and the four cells are the same size.
Linked issues
Refs #609.
Greptile Summary
This PR updates the demo GIF grid in
README.md, replacing a raw HTML<table>with a GFM markdown table wrapped in a<div align=\"center\">block, and reduces image dimensions from 460×260 to 440×220 to enforce a uniform 2:1 aspect ratio across all four cells.<table align=\"center\">withwidth/heighton each<img>was apparently not enforcing uniform sizing (likely because GitHub's HTML sanitizer stripped those attributes in that context); the markdown table approach preserves the<img>attributes as expected.Confidence Score: 5/5
Documentation-only change to README.md; no application code is modified and the change is safe to merge.
The change is confined to a markdown formatting adjustment in README.md. The GFM table + div align center pattern is well-established on GitHub and the blank-line separation ensures the inner table is processed as markdown rather than raw HTML. The only cosmetic side-effect is the empty header row inherent to GFM tables, which is minor and intentional.
No files require special attention — README.md is the only file changed.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[README.md Demo Section] --> B{Rendering approach} B -->|Before| C[HTML table align center img width=460 height=260] B -->|After| D[div align center GFM markdown table img width=440 height=220] C --> E[Browser may ignore width/height in sanitized HTML] D --> F[GitHub preserves img width/height attributes] E --> G[Cells render at native aspect ratios] F --> H[All cells render at uniform 440x220 2:1]Reviews (1): Last reviewed commit: "README: render 2x2 demo gifs at a unifor..." | Re-trigger Greptile