Skip to content

README: uniform demo gif sizing in the 2x2 grid#611

Merged
FuJacob merged 1 commit into
mainfrom
docs/readme-equal-gif-size
Jun 5, 2026
Merged

README: uniform demo gif sizing in the 2x2 grid#611
FuJacob merged 1 commit into
mainfrom
docs/readme-equal-gif-size

Conversation

@FuJacob
Copy link
Copy Markdown
Owner

@FuJacob FuJacob commented Jun 5, 2026

Summary

Switches the demo gif grid from a raw HTML table to a markdown table with explicit width and height on every img, so GitHub renders all four cells at an identical 440x220 box instead of falling back to native aspect ratios. The four source gifs vary from 1.7:1 to 2.9:1, so a uniform render size means a slight stretch but a clean grid.

Validation

Visual; previewed locally and the four cells are the same size.

Linked issues

Refs #609.

Greptile Summary

This PR updates the demo GIF grid in README.md, replacing a raw HTML <table> with a GFM markdown table wrapped in a <div align=\"center\"> block, and reduces image dimensions from 460×260 to 440×220 to enforce a uniform 2:1 aspect ratio across all four cells.

  • The old <table align=\"center\"> with width/height on each <img> was apparently not enforcing uniform sizing (likely because GitHub's HTML sanitizer stripped those attributes in that context); the markdown table approach preserves the <img> attributes as expected.
  • The 440×220 (2:1) constraint will lightly stretch or compress GIFs with non-2:1 native ratios — this is an intentional and documented trade-off in the PR description.

Confidence Score: 5/5

Documentation-only change to README.md; no application code is modified and the change is safe to merge.

The change is confined to a markdown formatting adjustment in README.md. The GFM table + div align center pattern is well-established on GitHub and the blank-line separation ensures the inner table is processed as markdown rather than raw HTML. The only cosmetic side-effect is the empty header row inherent to GFM tables, which is minor and intentional.

No files require special attention — README.md is the only file changed.

Important Files Changed

Filename Overview
README.md Replaces the HTML table demo grid with a markdown table inside a div align center block, reducing image dimensions from 460×260 to 440×220 (2:1 ratio) to enforce uniform cell sizing.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[README.md Demo Section] --> B{Rendering approach}
    B -->|Before| C[HTML table align center
 img width=460 height=260]
    B -->|After| D[div align center
 GFM markdown table
 img width=440 height=220]
    C --> E[Browser may ignore
width/height in sanitized HTML]
    D --> F[GitHub preserves
img width/height attributes]
    E --> G[Cells render at
native aspect ratios]
    F --> H[All cells render at
uniform 440x220 2:1]
Loading

Fix All in Codex Fix All in Claude Code

Reviews (1): Last reviewed commit: "README: render 2x2 demo gifs at a unifor..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@FuJacob FuJacob merged commit 36727d9 into main Jun 5, 2026
@FuJacob FuJacob deleted the docs/readme-equal-gif-size branch June 5, 2026 10:25
Comment thread README.md
Comment on lines +52 to +53
| | |
|:---:|:---:|
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The markdown table's empty header row (| | |) renders as a thin visible row above the GIF cells. There is no way to omit the header row in GFM syntax; this is a known markdown table limitation. The empty cells are fine as-is — just noting it renders a slightly elevated first row of GIFs, which is likely acceptable but worth being aware of as intentional.

Suggested change
| | |
|:---:|:---:|
| | |
|:---:|:---:|

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Codex Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant