Add allowFontScaling & fontSize props for Skip, Next, and Done labels#54
Open
fvonhoven wants to merge 6 commits into
Open
Add allowFontScaling & fontSize props for Skip, Next, and Done labels#54fvonhoven wants to merge 6 commits into
fvonhoven wants to merge 6 commits into
Conversation
added 6 commits
December 1, 2016 16:59
|
Merge pls |
|
Up ! Merge please !! |
|
Merge pls |
Author
|
@FuYaoDe Is there anything else I need to do to get this merged? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across an issue with the Skip & Done labels for devices that have larger font sizes enabled.
Added 2 props:
allowFontScalingprop to disable font scaling as an option (it istrueby default).fontSizeto allow setting of the size of the labelsUpdated README
(Also fixed what I thought was a typo in AppIntro.js - defaultStyles instead of defaulStyles)