-
Notifications
You must be signed in to change notification settings - Fork 18
feat(docker): Add multi-platform support for Docker build #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,7 @@ runs: | |
| id: publish | ||
| with: | ||
| context: ${{ inputs.context }} | ||
| platforms: linux/amd64,linux/arm64 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing QEMU setup breaks arm64 platform buildHigh Severity Adding Reviewed by Cursor Bugbot for commit 09dfbca. Configure here. |
||
| file: ${{ inputs.dockerfile }} | ||
| push: true | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-platform builds produce empty imageid output
Low Severity
Adding
platforms: linux/amd64,linux/arm64causesdocker/build-push-actionto produce an emptyimageidoutput, since multi-platform builds create a manifest list rather than a single image. The composite action still declaresimageidas an output and displays it in the build summary, both of which will now always be empty strings. Any downstream consumer relying on this output will silently receive no value.Additional Locations (2)
.github/actions/docker-publish/action.yaml#L34-L37.github/actions/docker-publish/action.yaml#L99-L100Reviewed by Cursor Bugbot for commit 09dfbca. Configure here.