Design Engineer 001 Submission — Abang Tah#2
Closed
abangtah wants to merge 1 commit into
Closed
Conversation
Contributor
|
@123abang Strong conversion thinking. Before we move forward, can you do a quick |
Author
|
Hello Sandie,
Quick clarification — when you say tighten to the brand guide, do you mean
a strict pass on colors, spacing, typography, and components, or also
adjusting layout where needed?
…On Wed, Mar 18, 2026 at 04:32 David Janczyn ***@***.***> wrote:
*sandiegodj* left a comment (FunnelEnvy/outperform#2)
<#2 (comment)>
@123abang <https://github.com/123abang> Strong conversion thinking.
Before we move forward, can you do a quick
pass to bring the implementation tighter to the brand guide?
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5IBCYJVXXSFXQKYZBAYNOL4RIKGVAVCNFSM6AAAAACWUJJX3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANZZGM4DIOBYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@123abang Strict pass on tokens, (colors, typography, spacing etc.) layout is your call. |
Author
|
Okay I’ll do that now . And update it when I do I will let you know . Have
a great day
…On Wed, Mar 18, 2026 at 15:10 David Janczyn ***@***.***> wrote:
*sandiegodj* left a comment (FunnelEnvy/outperform#2)
<#2 (comment)>
@123abang <https://github.com/123abang> Strict pass on tokens, (colors,
typography, spacing etc.) layout is your call.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5IBCYINH4HV4EBYUDTW6SD4RKU3TAVCNFSM6AAAAACWUJJX3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOBSHA3DGMBSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
c4eeec7 to
bb3eb85
Compare
Author
|
Done — I’ve tightened the implementation to strictly follow the Signalflow
brand tokens (colors, typography, spacing, and component specs). Also
cleaned up minor inconsistencies for better alignment.
Would appreciate a quick pass to confirm this is now aligned with what you
had in mind.
…On Wed, Mar 18, 2026 at 3:12 PM Abang Tah ***@***.***> wrote:
Okay I’ll do that now . And update it when I do I will let you know . Have
a great day
On Wed, Mar 18, 2026 at 15:10 David Janczyn ***@***.***>
wrote:
> *sandiegodj* left a comment (FunnelEnvy/outperform#2)
> <#2 (comment)>
>
> @123abang <https://github.com/123abang> Strict pass on tokens, (colors,
> typography, spacing etc.) layout is your call.
>
> —
> Reply to this email directly, view it on GitHub
> <#2 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A5IBCYINH4HV4EBYUDTW6SD4RKU3TAVCNFSM6AAAAACWUJJX3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOBSHA3DGMBSGQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Contributor
Author
|
Just pushed the updated version and opened the PR:
#9
Aligned the implementation strictly with the brand tokens as discussed.
Would appreciate a quick pass when you get a moment.
…On Thu, Mar 19, 2026 at 3:09 PM David Janczyn ***@***.***> wrote:
*sandiegodj* left a comment (FunnelEnvy/outperform#2)
<#2 (comment)>
Hey @123abang <https://github.com/123abang> - looks like your force-push
may have reverted your changes. The branch is back on the original commit (
bb3eb85
<bb3eb85>)
and the code still shows Tailwind CDN with no custom properties. You
probably had the updated version on c4eeec7
<c4eeec7>.
Can you check and re-push?
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5IBCYOVQE3OXXDAMUIBPNL4RP5QBAVCNFSM6AAAAACWUJJX3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOJQGQYDSMZQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Author
|
Hello David
just wanted to follow up on my submission here:
#9
Would love your feedback whenever you get a moment.
…On Thu, Mar 19, 2026 at 20:30 Abang Tah ***@***.***> wrote:
Just pushed the updated version and opened the PR:
#9
Aligned the implementation strictly with the brand tokens as discussed.
Would appreciate a quick pass when you get a moment.
On Thu, Mar 19, 2026 at 3:09 PM David Janczyn ***@***.***>
wrote:
> *sandiegodj* left a comment (FunnelEnvy/outperform#2)
> <#2 (comment)>
>
> Hey @123abang <https://github.com/123abang> - looks like your force-push
> may have reverted your changes. The branch is back on the original commit (
> bb3eb85
> <bb3eb85>)
> and the code still shows Tailwind CDN with no custom properties. You
> probably had the updated version on c4eeec7
> <c4eeec7>.
> Can you check and re-push?
>
> —
> Reply to this email directly, view it on GitHub
> <#2 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A5IBCYOVQE3OXXDAMUIBPNL4RP5QBAVCNFSM6AAAAACWUJJX3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOJQGQYDSMZQG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figma:
https://www.figma.com/design/h2lGs98T4DiSqr0ggVMrfR/Untitled?node-id=0-1&p=f&t=alTdKB12BL4nYo8p-0
Summary:
This submission refines the AI-generated wireframe into a conversion-focused landing page aligned with Signalflow’s brand system. All changes were made with a focus on real enterprise conversion behavior, not just aesthetics.
Key improvements:
Files are contained within:
challenges/design-engineer-001/submissions/abang-tah/