Allow linked reminders for different medicine#976
Draft
Arkonos wants to merge 1 commit intoFutsch1:mainfrom
Draft
Allow linked reminders for different medicine#976Arkonos wants to merge 1 commit intoFutsch1:mainfrom
Arkonos wants to merge 1 commit intoFutsch1:mainfrom
Conversation
Owner
|
@Arkonos Thanks a lot for your contribution, and also thanks for disclosing that you used AI!
One thing that keeps the PR from being merged is the fail of the tests, which are due to the additional UI interaction required when creating linked reminders. Please have a look at the androidTests that run there and fix them accordingly. Note: In order to run them locally, you need to set the date/time of the device to 1.8.25, 16:00 (or use the adb command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to allow the user to select a different medicine (B) for the linked reminder than (A) that of the parent reminder.
This would fulfil the original ask of #131 more closely.
When creating a linked reminder, the user will first be prompted to select one of the existing medicines from
medicineRepository.medicines. This list includes all, including A, but does not offer thecustomfield. Then the dose and delay have to be entered as before.As the user will still be at the medicine A and not see the new linked reminder, a toast message will inform about the creating of the same. The linked reminder can be seen edited in medicine B.
Since I am not familiar with Kotlin or Java, everything has been coded by AI so far.
I've tested it in an emulator and it works. Before investing more time, I wanted to ask if you're generally in favour of this approach.
Some questions for you
My personal use case is actually the same medication, but in a different dose. Since there are two different pills, I need to track the stock separately. With this PR, I can create
Medication A 5 mgandMedication A 10 mgand use a linked reminder.Having it under one medication would be cleaner, but would probably mean a lot of work.