Fix transmute_slice UB: add alignment, divisibility, and ZST guards#917
Open
kimjune01 wants to merge 1 commit into
Open
Fix transmute_slice UB: add alignment, divisibility, and ZST guards#917kimjune01 wants to merge 1 commit into
kimjune01 wants to merge 1 commit into
Conversation
Adds runtime checks before calling slice::from_raw_parts in transmute_slice, transmute_slice_mut (both fyrox-core and fyrox-texture): - Alignment assertion prevents misaligned pointer UB - Divisibility assertion catches truncated trailing bytes - ZST assertion prevents division by zero - Pod trait bounds on fyrox-core's public API ensure valid bit patterns Closes FyroxEngine#877
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slice::from_raw_partsto prevent misaligned pointer UB (reported in [Undefined Behavior] Misaligned Raw Pointer withtransmute_slice#877)Podtrait bounds tofyrox-core::transmute_sliceto ensure valid bit patterns for any byte sequencefyrox-texture's privatetransmute_sliceandtransmute_slice_mutTest plan
cargo check -p fyrox-core -p fyrox-texture -p fyrox-graphicspassesfyrox-graphics/src/uniform.rsthat calltransmute_slicestill passCloses #877