Skip to content

⚡ Optimize member list loading performance #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G30RG3-GJ wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ Optimize member list loading performance #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions src/library/assistant/ui/listmember/MemberListController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import java.util.logging.Logger;
import javafx.beans.property.SimpleStringProperty;
import javafx.collections.FXCollections;
import javafx.concurrent.Task;
import javafx.collections.ObservableList;
import javafx.event.ActionEvent;
import javafx.fxml.FXML;
Expand Down Expand Up @@ -75,22 +76,34 @@ private Stage getStage() {
private void loadData() {
list.clear();

DatabaseHandler handler = DatabaseHandler.getInstance();
String qu = "SELECT * FROM MEMBER";
ResultSet rs = handler.execQuery(qu);
try {
while (rs.next()) {
String name = rs.getString("name");
String mobile = rs.getString("mobile");
String id = rs.getString("id");
String email = rs.getString("email");
Task<List<Member>> task = new Task<List<Member>>() {
@Override
protected List<Member> call() throws Exception {
List<Member> memberList = new ArrayList<>();
DatabaseHandler handler = DatabaseHandler.getInstance();
String qu = "SELECT * FROM MEMBER";
ResultSet rs = handler.execQuery(qu);
while (rs.next()) {
String name = rs.getString("name");
String mobile = rs.getString("mobile");
String id = rs.getString("id");
String email = rs.getString("email");

memberList.add(new Member(name, id, mobile, email));
}
return memberList;
}
};

list.add(new Member(name, id, mobile, email));
task.setOnSucceeded(e -> {
list.setAll(task.getValue());
});

}
} catch (SQLException ex) {
Logger.getLogger(BookAddController.class.getName()).log(Level.SEVERE, null, ex);
}
task.setOnFailed(e -> {
Logger.getLogger(MemberListController.class.getName()).log(Level.SEVERE, "Failed to load members", task.getException());
});

new Thread(task).start();

tableView.setItems(list);
}
Expand Down