Inconsistent and Incomplete 3D Transform Implementation in Project Cards Leading to Layout Breaks and Accessibility Concerns..#71
Open
sushant-cloud wants to merge 1 commit intoGDGC-MET:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Corrections
![Uploading Screenshot 2025-10-09 at 1.46.05 PM.png…]()
Invalid linear-gradient Syntax: In .skills-bg, linear-gradient45deg was missing parentheses. It has been corrected to linear-gradient
Extra Comma in linear-gradient: The --gradient variable had a trailing comma var(--secondary),) which is invalid. The comma has been removed.
Conflicting animation Rules:
In .loading-ring, there were multiple conflicting animation properties and a 0s duration. I've combined them into a single, logical animation: animation: spin 1s linear infinite, fadeInUp 1s ease-out forwards;.
In .hero-text, the animation property was declared twice on the same line. The redundant part was removed.
Conflicting z-index: The .loading-screen had two z-index properties. I kept the higher value (z-index: 9999;) which is appropriate for a loading screen and removed the conflicting z-index: 1;.
Duplicate and Conflicting .project-card Rules: There were multiple, disconnected style blocks for .project-card and its inner elements. I've merged them into a single, coherent set of rules to prevent overrides and improve readability.
Invalid CSS Property tabindex: The property tabindex: 0; inside the .project-card rule is invalid CSS. tabindex is an HTML attribute, not a CSS property. It should be added directly to your HTML elements (e.g.,
Conflicting transform Properties: The .skill-card:hover selector had two separate transform rules. I combined them into one: transform: translateY(-10px) scale(1.1);.
Invalid opacity Value: In .project-overlay, the opacity: 90; was invalid (it must be between 0 and 1). For the hover effect to work as intended, I changed the initial opacity to 0.
Typo in Class Name: The class .skill-tagss was likely a typo for .skill-tag. I have corrected it.
Malformed Media Queries: All the media queries (e.g., @media max-width : 1024px":{) had incorrect syntax. I have fixed them to the correct format, for example: @media (max-width: 1024px) { ... }.
Redundant/Stray Rules: I removed a stray rule .skill-icon { color: red !important; } that was overriding other styles, and an extra closing brace } at the end of the file.