Database Models#2
Open
GEORGELECHA wants to merge 1 commit intomainfrom
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@database/booking.model.ts`:
- Around line 17-41: The schema currently only indexes eventId which allows
duplicate {eventId, email} bookings; update BookingSchema by removing the
single-field index on eventId and add a compound unique index on { eventId,
email } to enforce one booking per email per event (use BookingSchema.index({
eventId: 1, email: 1 }, { unique: true })). Ensure the new index is declared
after the schema definition so Mongoose applies it at model creation.
In `@database/event.model.ts`:
- Around line 55-66: The 12-hour parsing branch (the match12 result in
database/event.model.ts) currently accepts invalid inputs like "13:30 PM",
"00:30 AM", or minutes >59; add validation after parsing the captured groups to
ensure hours is between 1 and 12 and minutes is between 0 and 59 before applying
AM/PM conversion, and if invalid, reject/return an error or null instead of
continuing the conversion; update the logic around match12 handling (the
variables hours, minutes, period and the AM/PM conversion) to perform this guard
check first.
In `@lib/mongodb.ts`:
- Around line 52-64: dbConnect currently returns cached.conn unconditionally and
never clears cached.promise or cached.conn after a failed connect or later
disconnect; update dbConnect (and the cached handling around
cached.promise/cached.conn) to clear the cache on errors and on disconnects:
wrap the await of cached.promise in a try/catch and on catch set cached.promise
= null and cached.conn = null before rethrowing, and register a
mongoose.connection listener (e.g., 'disconnected' or 'close' and/or 'error')
that resets cached.conn and cached.promise to null so subsequent calls to
dbConnect will attempt a fresh mongoose.connect; reference cached.promise,
cached.conn, and the dbConnect function to locate the change.
In `@projectExplanation.md`:
- Line 1: Add a top-level H1 heading to the very start of projectExplanation.md
(above the existing first line "Zero type errors in the database/ files...") to
satisfy MD041; insert an H1 like "Project Explanation" as the first line so the
document has a primary title.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: abd4975d-0dfc-4496-b338-07cf285902a7
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (6)
database/booking.model.tsdatabase/event.model.tsdatabase/index.tslib/mongodb.tspackage.jsonprojectExplanation.md
Comment on lines
+17
to
+41
| const BookingSchema = new Schema<IBooking>( | ||
| { | ||
| eventId: { | ||
| type: Schema.Types.ObjectId, | ||
| ref: "Event", | ||
| required: [true, "Event ID is required"], | ||
| // Index for fast lookups when querying bookings by event | ||
| index: true, | ||
| }, | ||
| email: { | ||
| type: String, | ||
| required: [true, "Email is required"], | ||
| trim: true, | ||
| lowercase: true, | ||
| validate: { | ||
| validator: (v: string) => EMAIL_REGEX.test(v), | ||
| message: "Email must be a valid email address", | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| // Automatically adds createdAt and updatedAt fields | ||
| timestamps: true, | ||
| } | ||
| ); |
There was a problem hiding this comment.
Prevent duplicate bookings for the same event/email pair.
This schema currently allows multiple identical { eventId, email } documents. Since there is no quantity or ticket identifier on the record, retries and double-submits become indistinguishable duplicate bookings. Replace the single-field index with a compound unique index.
Proposed fix
eventId: {
type: Schema.Types.ObjectId,
ref: "Event",
required: [true, "Event ID is required"],
- // Index for fast lookups when querying bookings by event
- index: true,
},
@@
);
+
+BookingSchema.index({ eventId: 1, email: 1 }, { unique: true });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@database/booking.model.ts` around lines 17 - 41, The schema currently only
indexes eventId which allows duplicate {eventId, email} bookings; update
BookingSchema by removing the single-field index on eventId and add a compound
unique index on { eventId, email } to enforce one booking per email per event
(use BookingSchema.index({ eventId: 1, email: 1 }, { unique: true })). Ensure
the new index is declared after the schema definition so Mongoose applies it at
model creation.
Comment on lines
+55
to
+66
| // Try matching "H:MM AM/PM" or "HH:MM AM/PM" | ||
| const match12 = trimmed.match(/^(\d{1,2}):(\d{2})\s*(AM|PM)$/); | ||
| if (match12) { | ||
| let hours = parseInt(match12[1], 10); | ||
| const minutes = parseInt(match12[2], 10); | ||
| const period = match12[3]; | ||
|
|
||
| if (period === "PM" && hours !== 12) hours += 12; | ||
| if (period === "AM" && hours === 12) hours = 0; | ||
|
|
||
| return `${String(hours).padStart(2, "0")}:${String(minutes).padStart(2, "0")}`; | ||
| } |
There was a problem hiding this comment.
Validate 12-hour inputs before converting them.
13:30 PM, 00:30 AM, and 10:75 PM all match this branch today and get normalized into impossible 24-hour values. Reject out-of-range hours/minutes before applying the AM/PM conversion.
Proposed fix
const match12 = trimmed.match(/^(\d{1,2}):(\d{2})\s*(AM|PM)$/);
if (match12) {
let hours = parseInt(match12[1], 10);
const minutes = parseInt(match12[2], 10);
const period = match12[3];
+
+ if (hours < 1 || hours > 12 || minutes > 59) {
+ throw new Error(`Invalid time value: "${raw}"`);
+ }
if (period === "PM" && hours !== 12) hours += 12;
if (period === "AM" && hours === 12) hours = 0;
return `${String(hours).padStart(2, "0")}:${String(minutes).padStart(2, "0")}`;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@database/event.model.ts` around lines 55 - 66, The 12-hour parsing branch
(the match12 result in database/event.model.ts) currently accepts invalid inputs
like "13:30 PM", "00:30 AM", or minutes >59; add validation after parsing the
captured groups to ensure hours is between 1 and 12 and minutes is between 0 and
59 before applying AM/PM conversion, and if invalid, reject/return an error or
null instead of continuing the conversion; update the logic around match12
handling (the variables hours, minutes, period and the AM/PM conversion) to
perform this guard check first.
Comment on lines
+52
to
+64
| if (cached.conn) { | ||
| return cached.conn; | ||
| } | ||
|
|
||
| // If no connection promise exists yet, start one. | ||
| if (!cached.promise) { | ||
| cached.promise = mongoose.connect(MONGODB_URI as string, { | ||
| bufferCommands: false, | ||
| }); | ||
| } | ||
|
|
||
| // Await the pending connection and cache the result. | ||
| cached.conn = await cached.promise; |
There was a problem hiding this comment.
Reset the cache when the connection is no longer usable.
dbConnect() currently treats any non-null cached.conn as healthy and never clears a rejected cached.promise. After a transient connect error or a later disconnect, every caller keeps reusing the same dead state until the process restarts.
Proposed fix
async function dbConnect(): Promise<Mongoose> {
// Return the existing connection if it's already established.
- if (cached.conn) {
+ if (cached.conn?.connection.readyState === 1) {
return cached.conn;
}
+ if (cached.conn) {
+ cached.conn = null;
+ cached.promise = null;
+ }
// If no connection promise exists yet, start one.
if (!cached.promise) {
- cached.promise = mongoose.connect(MONGODB_URI as string, {
- bufferCommands: false,
- });
+ cached.promise = mongoose
+ .connect(MONGODB_URI as string, {
+ bufferCommands: false,
+ })
+ .catch((error) => {
+ cached.conn = null;
+ cached.promise = null;
+ throw error;
+ });
}
// Await the pending connection and cache the result.
cached.conn = await cached.promise;
return cached.conn;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if (cached.conn) { | |
| return cached.conn; | |
| } | |
| // If no connection promise exists yet, start one. | |
| if (!cached.promise) { | |
| cached.promise = mongoose.connect(MONGODB_URI as string, { | |
| bufferCommands: false, | |
| }); | |
| } | |
| // Await the pending connection and cache the result. | |
| cached.conn = await cached.promise; | |
| async function dbConnect(): Promise<Mongoose> { | |
| // Return the existing connection if it's already established. | |
| if (cached.conn?.connection.readyState === 1) { | |
| return cached.conn; | |
| } | |
| if (cached.conn) { | |
| cached.conn = null; | |
| cached.promise = null; | |
| } | |
| // If no connection promise exists yet, start one. | |
| if (!cached.promise) { | |
| cached.promise = mongoose | |
| .connect(MONGODB_URI as string, { | |
| bufferCommands: false, | |
| }) | |
| .catch((error) => { | |
| cached.conn = null; | |
| cached.promise = null; | |
| throw error; | |
| }); | |
| } | |
| // Await the pending connection and cache the result. | |
| cached.conn = await cached.promise; | |
| return cached.conn; | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@lib/mongodb.ts` around lines 52 - 64, dbConnect currently returns cached.conn
unconditionally and never clears cached.promise or cached.conn after a failed
connect or later disconnect; update dbConnect (and the cached handling around
cached.promise/cached.conn) to clear the cache on errors and on disconnects:
wrap the await of cached.promise in a try/catch and on catch set cached.promise
= null and cached.conn = null before rethrowing, and register a
mongoose.connection listener (e.g., 'disconnected' or 'close' and/or 'error')
that resets cached.conn and cached.promise to null so subsequent calls to
dbConnect will attempt a fresh mongoose.connect; reference cached.promise,
cached.conn, and the dbConnect function to locate the change.
| @@ -0,0 +1,18 @@ | |||
| Zero type errors in the database/ files. All three files compile cleanly against Mongoose v9. Here's a summary of what was created: | |||
There was a problem hiding this comment.
Add an H1 at the top of this document.
Line 1 starts with body text, which triggers MD041 and leaves the page without a primary title.
Proposed fix
-Zero type errors in the database/ files. All three files compile cleanly against Mongoose v9. Here's a summary of what was created:
+# Database model implementation notes
+
+Zero type errors in the database/ files. All three files compile cleanly against Mongoose v9. Here's a summary of what was created:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Zero type errors in the database/ files. All three files compile cleanly against Mongoose v9. Here's a summary of what was created: | |
| # Database model implementation notes | |
| Zero type errors in the database/ files. All three files compile cleanly against Mongoose v9. Here's a summary of what was created: |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@projectExplanation.md` at line 1, Add a top-level H1 heading to the very
start of projectExplanation.md (above the existing first line "Zero type errors
in the database/ files...") to satisfy MD041; insert an H1 like "Project
Explanation" as the first line so the document has a primary title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation