feat: Add missing tests for array helpers #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tArray already exist
RomainBaville
added
flag: ready for review
type: feature
type: cleanup
test-geos-integration
Comment on lines
-1042
to
-1053
| def sortArrayByGlobalIds( data: Union[ vtkCellData, vtkPointData ], arr: npt.NDArray[ np.float64 ] ) -> None: | ||
| """Sort an array following global Ids. | ||
| Args: | ||
| data (vtkFieldData): Global Ids array. | ||
| arr (npt.NDArray[ np.float64 ]): Array to sort. | ||
| """ | ||
| globalids: Optional[ npt.NDArray[ np.int64 ] ] = getNumpyGlobalIdsArray( data ) | ||
| if globalids is not None: | ||
| arr = arr[ np.argsort( globalids ) ] | ||
| else: | ||
| logging.warning( "No sorting was performed." ) |
Collaborator
There was a problem hiding this comment.
I am surprised by the complete removal of this function. The function getNumpyArrayByName is not a duplicate.
Contributor
Author
There was a problem hiding this comment.
You are right, it is not duplicated but It is not used and I do not fund any situation where it could be used. Even if a mesh is not sorted with global ID, for what I have seen, the global ID numerotation follows the one of the cell ID, the array does not need to be sort. But I can undo it if you think we need it.
| coordElementTo.add( cellPointsTo.GetPoint( idPointTo ) ) | ||
|
|
||
| idElementFrom: int = 0 | ||
| ElementFromFund: bool = False |
Collaborator
There was a problem hiding this comment.
Suggested change
| ElementFromFund: bool = False | |
| elementFromFund: bool = False |
Should be modified in the rest of the code also
| idElementFrom += 1 | ||
| elif isinstance( meshFrom, vtkMultiBlockDataSet ): | ||
| listDataSetFromIds: list[ int ] = getBlockElementIndexesFlatten( meshFrom ) | ||
| for DataSetFromId in listDataSetFromIds: |
Collaborator
There was a problem hiding this comment.
Suggested change
| for DataSetFromId in listDataSetFromIds: | |
| for dataSetFromId in listDataSetFromIds: |
idem
| listDataSetFromIds: list[ int ] = getBlockElementIndexesFlatten( meshFrom ) | ||
| for DataSetFromId in listDataSetFromIds: | ||
| dataSetFrom: vtkDataSet = vtkDataSet.SafeDownCast( meshFrom.GetDataSet( DataSetFromId ) ) | ||
| DataSetFromMap: npt.NDArray = computeElementMapping( dataSetFrom, meshTo, piece )[ 0 ] |
Collaborator
There was a problem hiding this comment.
Suggested change
| DataSetFromMap: npt.NDArray = computeElementMapping( dataSetFrom, meshTo, piece )[ 0 ] | |
| dataSetFromMap: npt.NDArray = computeElementMapping( dataSetFrom, meshTo, piece )[ 0 ] |
idem
Co-authored-by: paloma-martinez <104762252+paloma-martinez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amis to:
This PR close #209