Skip to content

Refactor workflows#10

Closed
ashiklom wants to merge 4 commits intoGEOS-ESM:mainfrom
ashiklom:shellscripts
Closed

Refactor workflows#10
ashiklom wants to merge 4 commits intoGEOS-ESM:mainfrom
ashiklom:shellscripts

Conversation

@ashiklom
Copy link

@ashiklom ashiklom commented Jun 2, 2024

  1. Move most of the actual testing logic into separate shell scripts.
    2. Use a workflow matrix to streamline the amount of code used. This should be a separate thing. I'll need to work through this.

I'm not 100% sure this is the correct approach. Let's discuss before merging!

@ashiklom ashiklom requested a review from a team as a code owner June 2, 2024 20:04
@ashiklom ashiklom force-pushed the shellscripts branch 2 times, most recently from 7313e8c to 6e5b7b6 Compare June 3, 2024 16:08
@mathomp4
Copy link
Member

mathomp4 commented Jun 3, 2024

Oh wow. Working through a fork. @ashiklom I guess you don't have write access? Let me give you that!

ETA: Okay. You should have write access. If you find you need admin access, let me know. At the moment that is just @jardizzo and @Dooruk , but CI workflows with GitHub Runners are odd enough that maybe you might need it...

@ashiklom ashiklom marked this pull request as draft June 4, 2024 20:00
@ashiklom
Copy link
Author

ashiklom commented Jun 4, 2024

Thanks @mathomp4!

Others: This needs a lot more work as I improve my understanding of how all of this works, so don't worry about doing any kind of review until I un-draft this (though comments are always welcome).

@ashiklom ashiklom closed this Jun 13, 2024
@ashiklom
Copy link
Author

Closed in favor of #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants