Open
Conversation
- Introduced a new method `_format_time` to convert seconds into HH:MM:SS format. - Enhanced `get_bookmarks` to return an empty list instead of None for books without titles. - Improved bookmark printing in `cmd_convert_audiobook` to include book titles and detailed bookmark information. - Updated filename generation for audio clips to include position in seconds. - Enhanced highlight extraction to include position seconds and formatted time in transcriptions.
GGyll
reviewed
Oct 27, 2025
Owner
GGyll
left a comment
GGyll
left a comment
There was a problem hiding this comment.
Seems like a lot of added logic just for time formatting? What else is going on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_format_timeto convert seconds into HH:MM:SS format.get_bookmarksto return an empty list instead of None for books without titles.cmd_convert_audiobookto include book titles and detailed bookmark information.