fix: corregir workflow de Lighthouse CI para iniciar servidor correct…#58
Merged
Conversation
|
@DevFBI is attempting to deploy a commit to the desenvolupadormaster-gmailcom's projects team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
- Eliminar cd ../.. de vercel.json (portfolio y lab) - Los comandos ahora se ejecutan desde root del monorepo - Actualizar workflow CI: pnpm 8 -> 9 para security audit - Mejorar manejo de errores en security audit
- Restaurar cd ../.. en buildCommand e installCommand - Agregar packageManager: pnpm@9.0.0 al package.json root - Esto es necesario cuando Vercel ejecuta desde apps/portfolio
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Switch from npm install -g pnpm to corepack for pnpm installation. Corepack is the official Node.js tool for managing package managers and has better compatibility with Vercel environment. ERR_INVALID_THIS persists even with pnpm@9.12.0 installed via npm, suggesting environment-level issue. Corepack provides better isolation and configuration. Commands: - corepack enable: Activates corepack - corepack prepare pnpm@9.12.0 --activate: Installs and activates pnpm Fixes #58
With Root Directory disabled in Vercel Dashboard, Vercel uses the repository root as working directory. The 'cd ../..' command is no longer needed and was causing errors. Changes: - Remove 'cd ../..' from buildCommand and installCommand - Add outputDirectory: 'apps/portfolio/.next' to specify Next.js output - Keep corepack for pnpm@9.12.0 installation Now commands run from repository root where pnpm-workspace.yaml and pnpm-lock.yaml are located. Fixes #58
- pnpm 9.12.0 has ERR_INVALID_THIS bug in Vercel environment - Regenerated lockfile with pnpm 8.15.9 (lockfileVersion 6.0) - This matches the stable version used successfully in production
|
Deployment failed with the following error: Learn More: https://vercel.com/desenvolupadormaster-gmailcoms-projects?upgradeToPro=build-rate-limit |
- Add useLocale() hook to Hero component for language detection - Update downloadCV() to serve cvEs.pdf or cvEn.pdf based on locale - Remove obsolete cvUrl property from personalInfo constant - Add CV files (cvEn.pdf and cvEs.pdf) to public directory Fixes CV download button to automatically download the correct language version based on the user's current interface language.
|
Deployment failed with the following error: Learn More: https://vercel.com/desenvolupadormaster-gmailcoms-projects?upgradeToPro=build-rate-limit |
- Add test for Spanish CV download (cvEs.pdf) when locale is 'es' - Add test for English CV download (cvEn.pdf) when locale is 'en' - Update renderHero helper to support multiple locales - Import English translations for EN locale tests - Maintain 100% test coverage for Hero component Tests validate that the correct CV file is downloaded based on the user's current interface language (i18n integration).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…amente
Descripción
Tipo de cambio
Issues relacionados
Closes #
Refs #
Cambios realizados
Screenshots
Checklist de Calidad
General
Testing
npm test)Build & Lint
npm run build)npm run lint)npm run formatonpm run format:check)Documentación
Performance & SEO
i18n (si aplica)
locales/es.jsonlocales/en.jsonuseTranslationshookAccesibilidad
Testing realizado
Entorno de prueba:
Navegadores probados:
Notas adicionales
Checklist del Revisor
Nota: Este repositorio es público y sirve como portfolio demo. Asegúrate de que el código cumple con altos estándares de calidad antes de hacer merge.