feat(lab): EN translations, fix routing and i18n#70
Conversation
* chore(portfolio): normalize line endings to LF Convert CRLF to LF across portfolio files for consistency * feat(portfolio): anonimizar proyectos y actualizar timeline profesional - Anonimizar todos los proyectos con nombres descriptivos genéricos (ej: 'Plataforma de Gestión Empresarial', 'Ecosistema Enterprise') - Actualizar timeline profesional con 5 experiencias y perÃodos hasta 2025 - Actualizar subtÃtulo de proyectos eliminando referencia directa a clientes - Corregir test de About para manejar múltiples elementos con año 2025 - Aplicar formato Prettier a archivos modificados * chore(monorepo): add .gitattributes to enforce LF line endings - Configure all text files to use LF on checkout - Renormalize existing files with CRLF - Prevent future CRLF issues in WSL/Windows environments --------- Co-authored-by: DevFBI <dev@fastbyte.es>
…stions - Resolve merge conflicts with feature/monorepo-docusaurus-lab - Add *.svg to .gitattributes for proper line ending handling - Fix empty achievements rendering in About.tsx (conditional ul) - Normalize CRLF to LF in all affected files
* feat(portfolio): update CV files for ES and EN * fix(ci): add permissions for PR comments and Lighthouse artifacts
* feat(portfolio): add LlarJove project with ia-chatbots category - Add 'ia-chatbots' to ProjectCategoryId union type - Add 'llarjove' slug to PROJECT_SLUGS - Add new category and LlarJove item to es.json and en.json * style(portfolio): fix Prettier formatting in translation files * style(portfolio): sort ProjectCategoryId and PROJECT_SLUGS alphabetically
…67) * feat(projects): redesign section with compact cards and detail modal * style(projects): apply prettier formatting * fix(modal): use ref pattern to avoid stale onClose dependency
Apply the same two-level pattern as Projects: compact SkillCard (icon + summary + first 3 skill pills + hover overlay with usage bars) opens a SkillModal with full skill metadata (description, years, projects, keywords). Adds `leadership` id to SkillCategory type and fixes the missing icon. 263 tests pass.
feat(lab): complete EN translations for blog, docs and homepage
|
Deployment failed with the following error: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the internationalization of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
GMNAPI
merged commit 4d9dbcb
into
feature/monorepo-docusaurus-lab
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a wide range of improvements across both the lab and portfolio applications. For the lab app, it successfully completes English translations, fixes routing issues related to trailingSlash, and enables the blog. For the portfolio app, it significantly refactors the projects and skills sections to use a more scalable and interactive modal-based UI. The code quality is excellent, with well-structured components and thorough tests for the new features. I have one suggestion to further improve performance on the new project cards. In the future, consider splitting large, unrelated changes into separate pull requests to streamline the review process.
| {/* Image / Gradient area */} | ||
| <div className="relative h-44 w-full overflow-hidden"> | ||
| {project.imageUrl ? ( | ||
| <img src={project.imageUrl} alt={project.title} className="h-full w-full object-cover" /> |
There was a problem hiding this comment.
For performance, consider adding loading="lazy" to this <img> tag. Since these cards are in a grid, lazy loading images that are off-screen can improve initial page load time and reduce unnecessary data transfer.
| <img src={project.imageUrl} alt={project.title} className="h-full w-full object-cover" /> | |
| <img src={project.imageUrl} alt={project.title} className="h-full w-full object-cover" loading="lazy" /> |
2 participants
Summary
/docs/intro→/en/docs/intro)<Translate>to homepage components (buttons, tagline, feature cards)trailingSlash: falseTest plan