fix(portfolio): fixed navbar positioning with viewport compensation#71
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! Esta solicitud de extracción aborda un problema de posicionamiento del navbar, asegurando que permanezca visible y correctamente alineado en la parte superior de la ventana gráfica. La solución implica una modificación fundamental en cómo se posiciona el navbar, pasando de un comportamiento Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Este PR corrige el posicionamiento de la barra de navegación cambiándola de sticky a fixed para evitar problemas con elementos padres que tengan overflow. Los cambios asociados incluyen la compensación del espacio en el layout principal y la actualización de los tests. En general, es una buena solución al problema. He dejado una sugerencia para mejorar la mantenibilidad del código al evitar un valor hardcodeado para la altura de la barra de navegación, utilizando en su lugar una variable CSS. Esto hará que el código sea más robusto y fácil de mantener en el futuro.
|
✅ CI Pipeline passed! All checks completed successfully. |
…ault in lab - portfolio: use resolvedTheme instead of theme in Navigation toggle logic and icon render to correctly handle defaultTheme='system' - lab: add colorMode config with defaultMode='dark' and respectPrefersColorScheme=true to mirror portfolio OS-aware behavior
…ation - Footer.test: URLs github/linkedin apuntan a perfil real (closes #72) - Navigation.test: mock de useTheme incluye resolvedTheme para toggle correcto
|
✅ CI Pipeline passed! All checks completed successfully. |
1 participant
Summary
Navigation.tsx: cambiasticky top-0→fixed inset-x-0 top-0para garantizar que el navbar flote sobre el contenido independientemente de ancestros conoverflowlayout.tsx: añadept-16en<main>para compensar los 64px que el nav ocupa fuera del flujo del documentoNavigation.test.tsx: actualiza la assertion de posicionamiento (sticky→fixed).gitignore: añade.cursorTest plan
npm run test:runpasa los 263 tests