feat(projects): replace curated project list with real screenshots#74
Merged
Conversation
- Replace 11 placeholder projects with 4 curated projects (CV + side) - Add gestiono-mi-negocio-facturacion, vita-liber-erp-interno, fastbyte-api-servicios, seedstockers-b2b-platform - Add real WebP screenshots for GestionoMiNegocio and VitaLiber - FastByte and Seedstockers use category gradient fallback (pending screenshots) - Update PROJECT_SLUGS for static route generation - Closes #73
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the portfolio's project list across English and Spanish translation files, replacing a large set of projects with four specific entries and adding image URLs. It also includes structural JSON reformatting and updates the project slug constants to reflect these changes. Feedback was provided regarding a typo in the image path for the 'GestionoMiNegocio' project in both language files, which would lead to broken images.
…new project data - Format messages/es.json and messages/en.json with Prettier - Replace hardcoded Next.js/GitHub tech assertions with data-driven checks using Symfony/TypeScript (present in current projects) - Make GitHub link tests data-driven: find first project with any external link (github or demo) to avoid false negatives
|
✅ CI Pipeline passed! All checks completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Rediseño de la sección de proyectos del portfolio: se sustituyen los 11 proyectos placeholder por una selección curada de 4 proyectos reales del CV y side projects, con screenshots WebP reales para 2 de ellos y gradiente de categoría como fallback para los 2 restantes (pendientes de screenshot).
Tipo de cambio
Issues relacionados
Closes #73
Cambios realizados
gestiono-mi-negocio-facturacion,vita-liber-erp-interno,fastbyte-api-servicios,seedstockers-b2b-platformpublic/images/projects/)PROJECT_SLUGSactualizado para generación estática de rutas de detalleScreenshots
Checklist de Calidad
General
Testing
Build & Lint
i18n
messages/es.jsonmessages/en.jsonAccesibilidad
project.title)Testing realizado
Entorno de prueba:
Notas adicionales
gestinio-mi-negocio.webpcontiene un typo ("gestinio" vs "gestiono") — es funcional, se puede corregir en un follow-up trivial.webpapublic/images/projects/y añadirimageUrlal item correspondiente en ambos JSONfeature/skills-card-modal-redesignpor proximidad con el trabajo de redesign del branch actual