Skip to content

Avoid accessing global document in webworker to fix https://github.com/GMOD/jbrowse-components/issues/5582 #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmdcolin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid accessing global document in webworker to fix https://github.com/GMOD/jbrowse-components/issues/5582 #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/jbrowse-plugin-apollo/src/LinearApolloSixFrameDisplay/glyphs/GeneGlyph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,11 @@
let backwardFillLight: CanvasPattern | null = null
let forwardFillDark: CanvasPattern | null = null
let backwardFillDark: CanvasPattern | null = null
const canvas = globalThis.document.createElement('canvas')
// @ts-expect-error getContext is undefined in the web worker
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (canvas?.getContext) {
// globalThis.document is undefined in the web worker, where this module is
// also loaded (but never uses these patterns, which are main-thread-only
// rendering fills)
const canvas = globalThis.document?.createElement('canvas')

Check failure on line 51 in packages/jbrowse-plugin-apollo/src/LinearApolloSixFrameDisplay/glyphs/GeneGlyph.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unnecessary optional chain on a non-nullish value

Check failure on line 51 in packages/jbrowse-plugin-apollo/src/LinearApolloSixFrameDisplay/glyphs/GeneGlyph.ts

View workflow job for this annotation

GitHub Actions / Strict lint and test 

Unnecessary optional chain on a non-nullish value
if (canvas) {

Check failure on line 52 in packages/jbrowse-plugin-apollo/src/LinearApolloSixFrameDisplay/glyphs/GeneGlyph.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unnecessary conditional, value is always truthy

Check failure on line 52 in packages/jbrowse-plugin-apollo/src/LinearApolloSixFrameDisplay/glyphs/GeneGlyph.ts

View workflow job for this annotation

GitHub Actions / Strict lint and test 

Unnecessary conditional, value is always truthy
for (const direction of ['forward', 'backward']) {
for (const themeMode of ['light', 'dark']) {
const canvas = document.createElement('canvas')
Expand Down
Loading