Adds E-Document support to digital voucher checks AB#108948#40
Open
AndriusAndrulevicius wants to merge 16 commits into
Open
Adds E-Document support to digital voucher checks AB#108948#40AndriusAndrulevicius wants to merge 16 commits into
AndriusAndrulevicius wants to merge 16 commits into
Conversation
Introduces E-Document as a new check type for digital vouchers, enforcing automatic generation and linking for purchase documents. Updates UI logic to ensure consistent behavior and validation. Extends data structures and event handling to support E-Document attachment and integration with related processes. Enables more robust compliance with regulatory requirements for electronic document management.
Adds feature flag and setup validations before attaching digital vouchers to documents, ensuring attachments only occur when the functionality is enabled and properly configured. Expands handling for purchase credit memos and improves type checks for both sales and purchase documents.
Streamlines digital voucher validation by generalizing E-Document attachment to support more document types and rely on record references rather than hardcoded field access or document types. Improves maintainability and feature extensibility by extracting document details via a dedicated method and refining permission set object ordering. Enhances code clarity and robustness in preparation for feature expansion.
Introduces comprehensive automated tests covering E-Document attachment behavior for sales and purchase documents, ensuring correct enforcement and attachment logic. Updates dependency declarations for better test isolation, removes unused variables, and improves error checking and file name handling for E-Document processing. Enhances reliability and maintainability of digital voucher and E-Document integration.
GMatuleviciute
requested changes
Feb 25, 2026
GMatuleviciute
changed the title
GMatuleviciute
changed the title
GMatuleviciute
changed the title
…herEntrySetup.Table.al Co-authored-by: Grasiele Matuleviciute <131970463+GMatuleviciute@users.noreply.github.com>
…herEntrySetup.Table.al Co-authored-by: Grasiele Matuleviciute <131970463+GMatuleviciute@users.noreply.github.com>
Refactors E-Document file attachment for purchase documents by relocating the logic from the check codeunit to the main implementation codeunit, improving code structure and responsibility separation. Updates test object ranges, enhances test reliability, and adjusts error handling to use labels for better localization. Clarifies and simplifies validation around E-Document requirements and streamlines page variable initialization. Improves maintainability and prepares for future extensibility.
…implements "Digital Voucher Check"
GMatuleviciute
approved these changes
Mar 4, 2026
Owner
|
Description: This pull request does not have a related issue as it's part of the delivery for development agreed directly with <> Implementation With this update enhanced automation for Digital Vouchers in sales and purchase document posting. When enabled, the system will automatically generate and attach E-Documents and related files to posted documents, streamlining document management and compliance. Functional Changes
When posting sales or purchase documents, if setup is set to use E-Documents the system will attach related E-Document files to the Incoming Document Files of the posted sales/purchase document. Impact
|
Improves observability by logging errors via feature telemetry when e-document attachment operations fail, including XML extraction from PDFs and incoming document imports. This helps diagnose issues in production without relying solely on user-reported errors. Refactors a purchase document test helper to separate the case where no e-document link is needed, removing an unnecessary guard condition and simplifying the overload that requires an e-document record. Also includes minor code style normalizations (variable reordering, lowercase `error()` calls) for consistency.
Replaces dynamic error text and call stack capture in telemetry logging with static, descriptive messages to avoid exposing potentially sensitive runtime details in telemetry. Reorders permission set entries to group tables, pages, and codeunits together for better readability and consistency. Also adds missing newlines at end of JSON and table files to follow standard file formatting conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces E-Document as a new check type for digital vouchers, enhancing compliance with electronic document management regulations. Updates UI logic and data structures to support automatic generation and linking of purchase documents.