Open
Conversation
We need to finish tests for dataset router and dataset service. The rest of the tests works.
Rira 17.unit tests
Created ADD,PUT and DELETE functionalities for arrangements and measure names
- deleted unnecessary prints and comments - add dataset methods to GriseraAPI - fixed get_datasets - create_dataset and delete_dataset need to be fixed
grisera api communicates with graph api to create a dataset of given name
there is an error with indexes (hope to fix it on Monday): File "/app/database_service.py", line 89, in check_if_database_exists grisera-framework-graph_api-1 | for db in response['results'][0]['data']: grisera-framework-graph_api-1 | IndexError: list index out of range
Before the creation of the dataset, the system checks if the database with this name already exists. If so, the database is not created and the user receives an error with the error cause
Auto creation during creating new dataset
Hash_name will be used as an identifier for the dataset by user
…ed in correct dataset When the dataset is created, inside it 4 types of nodes are created (35 nodes in total): - Alias - Channel - Life Activity - Modality
…Activity Added POST,DELETE and PUT for Activity
…rrangements-and-measure_names RIRA-25/26
…into RIRA-13.Managing-datasets
…into RIRA-13.Managing-datasets
…A/grisera-framework into RIRA-13.Managing-datasets
theNIGHTMAR3
left a comment
theNIGHTMAR3
left a comment
There was a problem hiding this comment.
A lot of work, finally done, great job!
mrwrob
requested changes
May 16, 2023
Member
mrwrob
left a comment
mrwrob
left a comment
There was a problem hiding this comment.
It seems fine, although it is not a big PR to analyze it deeply. Please address the comments.
graph_api/dataset/dataset_router.py
Outdated
| @router.get("/datasets", tags=["datasets"], response_model=DatasetsOut) | ||
| async def get_datasets(self, response: Response): | ||
| """ | ||
| Get all datasets by name |
graph_api/dataset/dataset_service.py
Outdated
Comment on lines
+86
to
+98
| # found = self.db.dataset_exists(name_hash) | ||
| # | ||
| # if not found: | ||
| # return DatasetOut(errors="Dataset not found") | ||
| # | ||
| # # get the alias from the DB | ||
| # get_aliases_response = self.db.get_aliases_from_database(name_hash) | ||
| # name_by_user = "" | ||
| # for row in get_aliases_response["results"][0]["data"]: | ||
| # if "row" in row: | ||
| # if "name_by_user" in row['row'][0]: | ||
| # name_by_user = row['row'][0]['name_by_user'] | ||
| # return DatasetOut(name_hash=name_hash, name_by_user=name_by_user) |
Member
There was a problem hiding this comment.
Why is this commented out? Please provide explanation in comments.
graph_api/database_service.py
Outdated
| Result of request | ||
| """ | ||
|
|
||
| # self.database_url = replace_db_name(self.database_url, database_name) |
Member
There was a problem hiding this comment.
Why is this commented out? Please provide explanation in comments.
|
You should add dataset_name parameter in appropriate functions in each abstract class ..._service. Not only in the implementations of these classes for graphdb. |
terzawad
requested changes
May 16, 2023
mrwrob
approved these changes
May 23, 2023
Member
mrwrob
left a comment
mrwrob
left a comment
There was a problem hiding this comment.
Next time, please respond to comments (e.g. corrected or done)
terzawad
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During working on this branch my team was able to accomplish several goals: