5434 - fallback the mime type to octet-stream #164
Merged
Conversation
…ad no format extension and the format field was blank
jbrown-xentity
left a comment
jbrown-xentity
left a comment
There was a problem hiding this comment.
LGTM, but you'll need to bump the version number so the build process can publish it appropriately in Pypi...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a url is provided, the import process will infer based on the extension, but if a user provides a dataset url with no extension, we can't figure out what the format is, especially when the user didn't specify the format type (it's optional in the form).
this fix will fallback on octet-stream if no proper format was provided so that it'll still put the dataset into the zip instead of throwing an error.