Skip to content

103 classifier 2d template restructure#104

Open
Ksonar262 wants to merge 4 commits intoTemplateV2from
103-classifier-2d-template-restructure
Open

103 classifier 2d template restructure#104
Ksonar262 wants to merge 4 commits intoTemplateV2from
103-classifier-2d-template-restructure

Conversation

@Ksonar262
Copy link
Copy Markdown

Linked Issue(s)

Explicitly tag the issue linked to this pull request, if any.
Closes #103

Summary of changes

Briefly describe the changes in this PR.
Renamed files and moved them around to match repo structure as discussed. Then fixed imports.

Reason for changes

Explain why these changes are being made
The changes are made to standardise code structure.

Clinical Risk Management Review

Summary of the clinical risk management review:

Briefly describe the outcome of the review and any actions taken.

Hazard Impact

Related Hazards: Include references to the Hazard Log e.g. HZ-xxx, HZ-yyy

Impact on Hazards:

  • Mitigates: List hazards it helps mitigate (e.g., HZ-xxx, HZ-yyy).
  • Induces: List hazards it might induce (e.g., HZ-xxx, HZ-yyy).

Quality Assurance

  • Unit tests added

@mikewoodward94
Copy link
Copy Markdown
Collaborator

Hey Kathan, could you ensure that this meets the new project structure?

Just from a quick review I can see that there's no project folder and the app folder is within the task, so could you fix this and anything else that's not quite in the right place?

Have attached the new structure for quick reference!

image

Copy link
Copy Markdown
Collaborator

@mikewoodward94 mikewoodward94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment!

@mikaelsimard5
Copy link
Copy Markdown

Hey Kathan,

doubling down on Mike's comments to follow the structure we set out previously. Attaching a slightly updated version of what Mike sent with the following changes:

  • modules such as dataloader and network are not capitalised per PEP guidelines;
  • each app/task should have a dedicated requirements.txt file.

In the structure we also now show that there is possibly more than one app just to be as general as possible but I don't think the template needs to have more than the app/ folder for now.

Furthermore we also discussed that it would be good to have some documentation on the philosophy behind the organisation of the folders and "what goes where" so that people getting started can follow good practices as we intended. This was to be set up in the wiki page - could you have a go at starting this as part of this PR? Happy to help if needed.

Screenshot 2026-04-01 at 09 55 40

@Ksonar262
Copy link
Copy Markdown
Author

Thanks both for the feedback and apologies for misunderstandings. I have updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants