Conversation
Author
|
Draft because I don't know how to make the thaumonomicon pages, which use the lang file entry, show the config value instead of the hardcoded. |
Dream-Master
added
the
🚧 Testing on Zeta
Ruling-0
reviewed
Feb 27, 2026
Ruling-0
left a comment
Ruling-0
left a comment
There was a problem hiding this comment.
Looks good overall, just some minor points.
Ruling-0
approved these changes
Feb 28, 2026
Dream-Master
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts wand capacity and caps to config so changes are not hardcoded.
Tested in devenv, changes to config are properly changed in game.