Skip to content

Remove Potassium Hydroxide, switch recipes to use GregTech Potassium Hydroxide + update GregTech dependency#1731

Open
loenaaaa wants to merge 4 commits intomasterfrom
potassium-hydroxide-unification
Open

Remove Potassium Hydroxide, switch recipes to use GregTech Potassium Hydroxide + update GregTech dependency#1731
loenaaaa wants to merge 4 commits intomasterfrom
potassium-hydroxide-unification

Conversation

@loenaaaa
Copy link
Copy Markdown
Contributor

@loenaaaa loenaaaa commented Apr 29, 2026

This PR removes the Potassium Hydroxide in this mod and switches the recipes it's used in with the GregTech Potassium Hydroxide to make it more unified with the material system. It has been tested using a dev environment with maven local testing, succesfully migrating existing Potassium Hydroxide, and also updates the gregtech dependency into the version that contains Potassium Hydroxide. An FML ignore has also been added for the old potassium hydroxide so it doesn't show a popup message. Please merge alongside GTNewHorizons/GT5-Unofficial#6552.

Fixes GTNewHorizons/GT-New-Horizons-Modpack#24456.

@loenaaaa loenaaaa marked this pull request as draft April 29, 2026 22:56
@loenaaaa
Copy link
Copy Markdown
Contributor Author

Update: Did some testing again, using maven local testing and having coremod KOH beforehand will successfully convert existing dust, but doing that while also deleting the dust makes existing dust be deleted.

@loenaaaa loenaaaa marked this pull request as ready for review April 29, 2026 23:40
@loenaaaa
Copy link
Copy Markdown
Contributor Author

Update 2: It managed to work after fixing the postea transformer to reference it correctly.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label May 1, 2026
Copy link
Copy Markdown
Contributor

@Nikolay-Sitnikov Nikolay-Sitnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove the lang key and the texture files for the old item.

@loenaaaa
Copy link
Copy Markdown
Contributor Author

loenaaaa commented May 2, 2026

You also need to remove the lang key and the texture files for the old item.

Alright, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Fix a bug. Please link it in the PR. 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate Materials

3 participants