Remove Potassium Hydroxide, switch recipes to use GregTech Potassium Hydroxide + update GregTech dependency#1731
Open
Remove Potassium Hydroxide, switch recipes to use GregTech Potassium Hydroxide + update GregTech dependency#1731
Conversation
Contributor
Author
|
Update: Did some testing again, using maven local testing and having coremod KOH beforehand will successfully convert existing dust, but doing that while also deleting the dust makes existing dust be deleted. |
Contributor
Author
|
Update 2: It managed to work after fixing the postea transformer to reference it correctly. |
Nikolay-Sitnikov
requested changes
May 2, 2026
Contributor
Nikolay-Sitnikov
left a comment
There was a problem hiding this comment.
You also need to remove the lang key and the texture files for the old item.
… into potassium-hydroxide-unification
Contributor
Author
Alright, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the Potassium Hydroxide in this mod and switches the recipes it's used in with the GregTech Potassium Hydroxide to make it more unified with the material system. It has been tested using a dev environment with maven local testing, succesfully migrating existing Potassium Hydroxide, and also updates the gregtech dependency into the version that contains Potassium Hydroxide. An FML ignore has also been added for the old potassium hydroxide so it doesn't show a popup message. Please merge alongside GTNewHorizons/GT5-Unofficial#6552.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#24456.