feat(appeng): enhance appeng integration APIs#188
Merged
Luca-Guettinger merged 8 commits intoGTNewHorizons:masterfrom Apr 25, 2026
Merged
feat(appeng): enhance appeng integration APIs#188Luca-Guettinger merged 8 commits intoGTNewHorizons:masterfrom
Luca-Guettinger merged 8 commits intoGTNewHorizons:masterfrom
Conversation
Luca-Guettinger
requested changes
Apr 24, 2026
Luca-Guettinger
left a comment
Luca-Guettinger
left a comment
There was a problem hiding this comment.
The critical issue is the silent default change from 64 to 1 on the database path of requestItems, which will break existing OC programs.
Luca-Guettinger
requested changes
Apr 25, 2026
Luca-Guettinger
left a comment
Luca-Guettinger
left a comment
There was a problem hiding this comment.
The !args.isInteger(2) fix for the default amount breaks the table path by overriding "size", and getStackFromDatabase is the wrong utility for the fluid database path because it consumes the amount argument as an irrelevant ItemStack stackSize.
Luca-Guettinger
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enhance appeng integration APIs