Skip to content

refactor: storeName 필드 추가#287

Merged
Jjiggu merged 1 commit intodevelopfrom
refactor/#286-add-storeName
Aug 22, 2025
Merged

refactor: storeName 필드 추가#287
Jjiggu merged 1 commit intodevelopfrom
refactor/#286-add-storeName

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Aug 22, 2025

작업 요약

  • storeName 필드 추가

Issue Link

#286

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 신기능
    • 메뉴 조회 응답에 매장명(storeName)이 추가되어, 화면에서 메뉴와 함께 매장명을 확인할 수 있습니다.
    • 클라이언트는 새 필드 storeName을 활용해 매장 정보를 표시할 수 있습니다.
  • 문서화
    • 응답 스키마에 storeName 필드가 추가되었습니다. 기존 필드는 변경되지 않아 하위 호환에 영향이 없습니다.

@Jjiggu Jjiggu self-assigned this Aug 22, 2025
@Jjiggu Jjiggu added the refactor 리팩토링 label Aug 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

MenuReadResponse DTO에 storeName 필드를 추가하고, 정적 팩터리 메서드 시그니처를 (String storeName, List)로 변경했습니다. MenuService에서는 Store를 조회해 storeName을 추출하고, MenuReadResponse.of 호출 시 storeName을 전달하도록 수정했습니다.

Changes

Cohort / File(s) Summary of Changes
DTO 업데이트
nowait-app-user-api/src/main/java/com/nowait/applicationuser/menu/dto/MenuReadResponse.java
필드 storeName:String 추가. 팩터리 메서드 시그니처 of(String storeName, List<MenuReadDto>)로 변경 및 빌더에 storeName 설정.
Service 업데이트
nowait-app-user-api/src/main/java/com/nowait/applicationuser/menu/service/MenuService.java
Store 조회 로직에서 store.getName()으로 storeName 추출. MenuReadResponse.of(storeName, menuReadResponse)로 호출 변경. 관련 import 추가.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Client
  participant S as MenuService
  participant SR as StoreRepository
  participant MR as MenuRepository
  participant DTO as MenuReadResponse

  C->>S: getMenu(storeId)
  S->>SR: findById(storeId)
  SR-->>S: Store or NotFound
  alt Store not found
    S-->>C: throw StoreNotFoundException
  else Store found
    S->>MR: findMenusByStoreId(storeId)
    MR-->>S: List<MenuReadDto>
    S->>DTO: of(store.name, menuReadDtoList)
    DTO-->>S: MenuReadResponse
    S-->>C: MenuReadResponse
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • HyemIin

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ea22b97 and 3b9fb71.

📒 Files selected for processing (2)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/menu/dto/MenuReadResponse.java (1 hunks)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/menu/service/MenuService.java (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/#286-add-storeName

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from HyemIin August 22, 2025 07:10
@Jjiggu Jjiggu merged commit 9c65f6f into develop Aug 22, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant