Skip to content

bug: 웨이팅 등록 cors 버그 임시 수정#293

Merged
Jjiggu merged 1 commit intodevelopfrom
feature/#290-public-code
Aug 27, 2025
Merged

bug: 웨이팅 등록 cors 버그 임시 수정#293
Jjiggu merged 1 commit intodevelopfrom
feature/#290-public-code

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Aug 27, 2025

작업 요약

웨이팅 등록 cors 버그 임시 수정

Issue Link

#290

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 신규 기능
    • 해당 없음
  • 버그 수정
    • 특정 양식 제출 및 API 호출 시 간헐적으로 발생하던 인증/토큰 검증 오류를 해소하여 로그인 상태에서의 작업 안정성이 향상되었습니다.
    • 예외적으로 요구되던 추가 토큰 절차가 제거되어 페이지 전환과 데이터 저장 흐름이 더 매끄럽습니다.
  • 기타(Chores)
    • 보안 설정을 단순화해 요청 처리의 일관성과 호환성을 개선했습니다.

@Jjiggu Jjiggu self-assigned this Aug 27, 2025
@Jjiggu Jjiggu added the bug Something isn't working label Aug 27, 2025
@Jjiggu Jjiggu merged commit 07cb382 into develop Aug 27, 2025
1 of 2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Aug 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

CSRF 설정이 엔드포인트별 예외/쿠키 저장소 기반 구성에서 전면 비활성화(csrf(AbstractHttpConfigurer::disable))로 변경되었습니다. CookieCsrfTokenRepository와 특정 경로 무시 설정이 제거되었고, 공개 API 시그니처 변경은 없습니다.

Changes

Cohort / File(s) Summary
Security configuration
nowait-app-user-api/src/main/java/com/nowait/applicationuser/config/security/SecurityConfig.java
CookieCsrfTokenRepository 및 ignoringRequestMatchers 제거, CSRF 전역 비활성화로 교체, 보안 동작 변경(메서드 시그니처 변화 없음)

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Client
  participant S as SecurityFilterChain
  participant A as App

  Note over S: 변경 후 (CSRF 비활성화)
  C->>S: HTTP 요청
  S-->>A: 인증/인가 처리 (CSRF 검증 없음)
  A-->>S: 응답
  S-->>C: HTTP 응답
Loading
sequenceDiagram
  autonumber
  participant C as Client
  participant S as SecurityFilterChain
  participant CSRF as CsrfFilter
  participant A as App

  rect rgba(220,240,255,0.5)
  Note over S,CSRF: 변경 전 (CSRF 활성 + 일부 경로 예외)
  C->>S: HTTP 요청
  S->>CSRF: CSRF 토큰 검증(예외 경로는 건너뜀)
  CSRF-->>S: 통과 또는 거부
  end
  S-->>A: 인증/인가 처리
  A-->>S: 응답
  S-->>C: HTTP 응답
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • HyemIin

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 895d106 and 8ff156b.

📒 Files selected for processing (1)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/config/security/SecurityConfig.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#290-public-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from HyemIin August 27, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant