Skip to content

bug: 타임존 수정#295

Merged
Jjiggu merged 1 commit intodevelopfrom
feature/#290-public-code
Aug 27, 2025
Merged

bug: 타임존 수정#295
Jjiggu merged 1 commit intodevelopfrom
feature/#290-public-code

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Aug 27, 2025

작업 요약

타임존 수정

Issue Link

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 새 기능
    • 없음
  • 버그 수정
    • 컨테이너와 애플리케이션에 Asia/Seoul 시간대를 명시해 로그·스케줄 시간의 일관성을 확보했습니다.
    • JVM 옵션 위치를 바로잡아 시간대 및 보안 난수 설정이 정상적으로 적용되도록 수정했습니다.
  • 잡무
    • 관리/사용자 API 서비스에 환경 변수로 시간대 설정을 추가해 배포 환경에서 동일한 시간대가 보장되도록 했습니다.

@Jjiggu Jjiggu self-assigned this Aug 27, 2025
@Jjiggu Jjiggu merged commit b7298c8 into develop Aug 27, 2025
1 of 2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Aug 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

두 Dockerfile과 두 docker-compose 파일에서 컨테이너 시간대(TZ=Asia/Seoul) 설정을 추가하고, Java 실행 옵션(-D...)을 -jar 이전으로 이동하여 JVM 옵션으로 처리되도록 명령 순서를 수정했다. 서비스/프로필 등 다른 설정은 변경되지 않았다.

Changes

Cohort / File(s) Change Summary
Compose: TZ 환경변수 추가
docker-compose.admin.yml, docker-compose.user.yml
각 compose에서 nowait-app-*-api 서비스에 environment: TZ=Asia/Seoul 추가. 다른 필드는 동일.
Dockerfiles: TZ 설정 및 JVM 옵션 위치 수정
nowait-app-admin-api/Dockerfile, nowait-app-user-api/Dockerfile
ENV TZ=Asia/Seoul 추가. -Djava.security.egd-Duser.timezone-jar 앞(JVM 옵션)으로 이동. 애플리케이션 인자(`--spring.profiles.active=admin

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

bug

Suggested reviewers

  • HyemIin

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9fb79f5 and 572e3da.

📒 Files selected for processing (4)
  • docker-compose.admin.yml (1 hunks)
  • docker-compose.user.yml (1 hunks)
  • nowait-app-admin-api/Dockerfile (1 hunks)
  • nowait-app-user-api/Dockerfile (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#290-public-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from HyemIin August 27, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant