Skip to content

refactor: 휴대폰 번호 검증 로직 변경#316

Merged
Jjiggu merged 1 commit intodevelopfrom
feature/#310-phoneNumber
Sep 9, 2025
Merged

refactor: 휴대폰 번호 검증 로직 변경#316
Jjiggu merged 1 commit intodevelopfrom
feature/#310-phoneNumber

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Sep 9, 2025

작업 요약

  • 휴대폰 번호 검증 로직 변경 (하이폰 제거)

Issue Link

#310

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • Bug Fixes
    • 회원 정보 수정 시 휴대폰 번호 검증을 하이픈 포함 형식(010-0000-0000)에서 숫자만 11자리(01000000000)로 통일했습니다. 이제 하이픈이 포함된 입력은 허용되지 않습니다.
    • 잘못된 형식 입력 시 표시되는 안내 메시지를 숫자 11자리 형식에 맞게 업데이트하여 더 명확한 피드백을 제공합니다.

@Jjiggu Jjiggu self-assigned this Sep 9, 2025
@Jjiggu Jjiggu added the refactor 리팩토링 label Sep 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

UserUpdateRequest의 phoneNumber 유효성 검사 정규식과 메시지가 하이픈 포함 형식에서 숫자만 11자리 형식으로 변경되었습니다. 다른 필드는 변경되지 않았습니다.

Changes

Cohort / File(s) Summary
Validation rule update
nowait-app-user-api/src/main/java/com/nowait/applicationuser/user/dto/UserUpdateRequest.java
phoneNumber@Pattern 정규식이 ^010-\d{4}-\d{4}$에서 ^010\d{4}\d{4}$로 변경; 검증 메시지를 "010-0000-0000"에서 "01000000000" 형식으로 수정

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • HyemIin

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8708e8a and 6ac2c8c.

📒 Files selected for processing (1)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/user/dto/UserUpdateRequest.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#310-phoneNumber

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot requested a review from HyemIin September 9, 2025 12:51
@Jjiggu Jjiggu merged commit 3fbc3c3 into develop Sep 9, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant