Skip to content

refactor: 시큐리티 설정 변경#33

Merged
Jjiggu merged 1 commit intodevelopfrom
feature/#29-swagger-doc
Jul 1, 2025
Merged

refactor: 시큐리티 설정 변경#33
Jjiggu merged 1 commit intodevelopfrom
feature/#29-swagger-doc

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Jul 1, 2025

작업 요약

Issue Link

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 버그 수정
    • 인증 없이 접근 가능한 엔드포인트가 변경되었습니다. 이제 "/orders/**" 경로만 인증 없이 접근할 수 있으며, 기존의 메뉴 및 매장 관련 경로는 인증이 필요합니다.

@coderabbitai
Copy link

coderabbitai bot commented Jul 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

HTTP 보안 설정이 변경되어 인증 없이 접근 가능한 URL 패턴 목록이 조정되었습니다. 관리자와 프론트엔드 보안 설정 모두에서 메뉴 및 매장 관련 엔드포인트의 permit-all이 제거되고, 주문 관련 엔드포인트("/orders/**")만 인증 없이 접근할 수 있도록 변경되었습니다.

Changes

파일 경로 변경 요약
security-admin/.../auth/config/SecurityConfig.java
security-front/.../auth/config/SecurityConfig.java
인증 없이 접근 가능한 URL 패턴 목록에서 메뉴 및 매장 관련 경로를 제거하고, 주문 관련 경로("/orders/**")만 permit-all로 설정함

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SecurityConfig
    participant Application

    User->>SecurityConfig: HTTP 요청 (예: /orders/123)
    SecurityConfig-->>User: 인증 없이 허용 (permit-all)
    User->>SecurityConfig: HTTP 요청 (예: /admin/menus/1 또는 /v1/menus/1)
    SecurityConfig-->>User: 인증 필요 (permit denied)
Loading

Suggested reviewers

  • HyemIin

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbe8d0c and dc1259b.

📒 Files selected for processing (2)
  • security-admin/src/main/java/com/nowait/adminsecurity/auth/config/SecurityConfig.java (1 hunks)
  • security-front/src/main/java/com/nowait/frontsecurity/auth/config/SecurityConfig.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jjiggu Jjiggu merged commit 030f79f into develop Jul 1, 2025
1 of 2 checks passed
@github-actions github-actions bot requested a review from HyemIin July 1, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant